Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local site favicon is replaced by Brave favicon when clicked Learn more link #22214

Closed
MadhaviSeelam opened this issue Apr 11, 2022 · 3 comments · Fixed by brave/brave-core#12994
Assignees
Labels
bug feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 11, 2022

Description

Website favicon is replaced by Brave favicon when clicked Learn more link in the shields panel

Steps to Reproduce

  1. Install 1.38.83
  2. Launch Brave
  3. Visit Washingtonpost.com
  4. Click Shields icon
  5. Click Learn more link below Trackers, ads and more blocked in the shields panel
  6. Click Shields icon in Brave.com/privacy-features page
  7. Return to previous tab Wasingtonpost.com
  8. Click Shields

Actual result:

Washingtonpost.com favicon is replaced by Brave favicon in the shields panel

Learnmore

Expected result:

Washingtonpost.com favicon should display as expected in the shields panel

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.38.83 Chromium: 100.0.4896.79 (Official Build) beta (64-bit)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS Windows 11 Version 21H2 (Build 22000.593)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@MadhaviSeelam MadhaviSeelam added bug OS/Desktop feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. QA/Test-Plan-Specified labels Apr 11, 2022
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". QA/Yes release-notes/exclude labels Apr 11, 2022
@rebron rebron added this to Untriaged Backlog in General Apr 12, 2022
@rebron rebron moved this from Untriaged Backlog to P4 Backlog in General Apr 12, 2022
@rebron rebron removed the priority/P4 Planned work. We expect to get to it "soon". label Apr 12, 2022
@rebron rebron moved this from P4 Backlog to On Deck in General Apr 12, 2022
@rebron rebron added feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) priority/P2 A bad problem. We might uplift this to the next planned release. labels Apr 12, 2022
@rebron rebron removed their assignment Apr 12, 2022
General automation moved this from On Deck to Completed Apr 13, 2022
@nullhook nullhook added this to the 1.39.x - Nightly milestone Apr 14, 2022
@kjozwiak
Copy link
Member

Above requires 1.38.102 or higher for 1.38.x verification.

@GeetaSarvadnya
Copy link

Verification PASSED on


Brave | 1.38.103 Chromium: 100.0.4896.127 (Official Build) beta (64-bit)
-- | --
Revision | ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS | Windows 10 Version 21H2 (Build 19044.1645)

  • Verified the STR from the description and ensured the site favicon is shown correctly on both the sites.

@MadhaviSeelam
Copy link
Author

Verification Passed on

Brave 1.38.104 Chromium: 101.0.4951.41 (Official Build) (64-bit)
Revision 93c720db8323b3ec10d056025ab95c23a31997c9-refs/branch-heads/4951@{#904}
OS Windows 11 Version 21H2 (Build 22000.613)

Verified the bug fix. QA complete.

@rebron rebron removed this from Completed in General May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants