-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site banner should have 'on YouTube' text when appropriate #2238
Labels
Milestone
Comments
This was referenced Nov 28, 2018
ryanml
added a commit
to ryanml/brave-core
that referenced
this issue
Nov 28, 2018
18 tasks
ryanml
added a commit
to ryanml/brave-core
that referenced
this issue
Nov 28, 2018
ryanml
added a commit
to ryanml/brave-core
that referenced
this issue
Nov 30, 2018
ryanml
added a commit
to ryanml/brave-core
that referenced
this issue
Nov 30, 2018
ryanml
added a commit
to ryanml/brave-core
that referenced
this issue
Nov 30, 2018
ryanml
added a commit
to ryanml/brave-core
that referenced
this issue
Dec 2, 2018
ryanml
added a commit
to ryanml/brave-core
that referenced
this issue
Dec 3, 2018
ryanml
added a commit
to ryanml/brave-core
that referenced
this issue
Dec 3, 2018
ryanml
added a commit
to ryanml/brave-core
that referenced
this issue
Dec 3, 2018
ryanml
added a commit
to ryanml/brave-core
that referenced
this issue
Dec 3, 2018
Verified passed with
Verification passed on
Verification passed on Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
When you go to tip a YouTube channel, the site banner now says the channel name and displays channel favicon. However, site banner does not indicate that the site is 'on YouTube' as it does on the Brave panel (when you click on BAT logo) or on the Brave Rewards page (in AutoContribute table).
Steps to Reproduce
Actual result:
Site banner displays, but does not have 'on YouTube' text:
![screen shot 2018-11-26 at 4 12 57 pm](https://user-images.githubusercontent.com/28145373/49044031-afb60780-f19a-11e8-80da-470ff8c61880.png)
Expected result:
Site banner should note 'on YouTube' to be consistent with Brave panel and Brave Rewards page.
Reproduces how often:
easily
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information
The 'on YouTube' text also displays on the brave://rewards page:
![screen shot 2018-11-26 at 4 12 46 pm](https://user-images.githubusercontent.com/28145373/49044108-dbd18880-f19a-11e8-8b83-00795a667bd3.png)
The text was updated successfully, but these errors were encountered: