Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect favicon is shown when the shield toggle is turned OFF and ON #22415

Closed
Tracked by #22546
GeetaSarvadnya opened this issue Apr 20, 2022 · 2 comments
Closed
Tracked by #22546
Assignees
Labels
bug feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Apr 20, 2022

Description

An incorrect favicon is shown when the shield toggle is turned OFF and ON

Steps to Reproduce

  1. Clean profile 1.38.103
  2. Open Theverge.com or cnn.com or cnet.com
  3. Open the shield and turn OFF and ON the shield multiple times

Actual result:

An incorrect favicon is shown when the shield toggle is turned OFF and ON

Recorded file path:
https://drive.google.com/file/d/1gopSKc8iHxrXr3KxMXFhcYIxKmx1MMj0/view?usp=sharing

Expected result:

the correct favicon should be shown when the shield toggle is turned OFF and ON

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.38.103 Chromium: 100.0.4896.127 (Official Build) beta (64-bit)
Revision ff0d0695743e65305d7194f9bd309e5e1c824aa0-refs/branch-heads/4896_88@{#4}
OS Windows 10 Version 21H2 (Build 19044.1645)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @nullhook @rebron @brave/qa-team

@rebron rebron mentioned this issue Apr 25, 2022
7 tasks
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 26, 2022
@rebron rebron added this to the 1.41.x - Nightly milestone Jun 1, 2022
@rebron
Copy link
Collaborator

rebron commented Jun 1, 2022

Closed with brave/brave-core#13209

@GeetaSarvadnya
Copy link
Author

Verification PASSED on

Brave | 1.41.46 Chromium: 102.0.5005.78 (Official Build) nightly (64-bit)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Windows 10 Version 21H2 (Build 19044.1706)

  • Verified the STR from the description and ensured the correct favicon is shown when the shield is toggled
    favicon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants