Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send/Buy from token page doesn't select the token as default #22574

Closed
srirambv opened this issue Apr 27, 2022 · 1 comment · Fixed by brave/brave-core#13815
Closed

Send/Buy from token page doesn't select the token as default #22574

srirambv opened this issue Apr 27, 2022 · 1 comment · Fixed by brave/brave-core#13815
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Send/Buy from token page doesn't select the token as default

Steps to reproduce

  1. Select BAT Token from portfolio
  2. Click on Buy/Send
  3. Default token is set to ETH and not BAT
  4. Select Swap from BAT Token page, BAT is set as default

Actual result

Incorrect.token.for.Buy.Send.mp4

Expected result

Should default to the selected token from which the Buy/Send action is triggered

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.37.116 & 1.38.108

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Pavneet-Sing @qamarngr

@srirambv srirambv added bug QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Apr 27, 2022
@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 7, 2022
@wchen342 wchen342 added this to the 1.42.x - Nightly milestone Jun 21, 2022
@srirambv
Copy link
Contributor Author

Verification passed on the following devices running 1.42.65 x64 Beta build

  • Verified steps from issue description
  • Verified Send/Buy from token page is set as default
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
22574-ARM.mp4
22574-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants