Fix a potential bug while setting brave as default

[Pavneet-Sing]

Description

The BraveSetDefaultBrowserUtils.setBraveDefaultSuccess(); will never be executed as MONTHLY_CONTRIBUTION_REQUEST_CODE and DEFAULT_BROWSER_ROLE_REQUEST_CODE Both have same values. MONTHLY_CONTRIBUTION_REQUEST_CODE == DEFAULT_BROWSER_ROLE_REQUEST_CODE

        } else if (resultCode == RESULT_OK && requestCode == 36) {
            dismissRewardsPanel();

        } else if (resultCode == RESULT_OK
                && requestCode == 36) {
            BraveSetDefaultBrowserUtils.setBraveDefaultSuccess();
        }

so the setBraveDefaultSuccess will never be executed.

Actual result

Haven't tested this use case but looks like it can affect set default browser flow, where it will always trigger dismissRewardsPanel instead of setBraveDefaultSuccess.

Expected result

• DEFAULT_BROWSER_ROLE_REQUEST_CODE should have a different value than MONTHLY_CONTRIBUTION_REQUEST_CODE constant
• Alternately, Prefer to create a separate constant class for public constants (instead of in Utils file) and move BraveActivity's public constant to the constant file as well if suitable.

Issue reproduces how often

easy

Additional information

Not sure which constant value should be changed, though usually should be latter one.
cc: @tapanmodh, Tagging @srirambv to verify the flow, if required.

[tapanmodh]

@Pavneet-Sing Nice catch! I'll fix it

[Uni-verse]

Verification PASSED on Samsung Galaxy S21 & Tab S7 using

Brave	1.40.91 Chromium: 102.0.5005.78 (Official Build) beta (64-bit) 
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	Android 12; Build/SP1A.210812.016

• Confirmed user gets prompted to select default browser after using the set default browser in 3-dot menu
• Confirmed selecting brave from the default browser prompt will remove setting from menu.
• Confirmed opening link in browser option will launch url in brave browser.
• Confirmed user is able to make monthly contribution to publisher after setting brave as default.

1	2	3	4