Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement text-fragments (with sufficient privacy protections) #22906

Open
pes10k opened this issue May 17, 2022 · 3 comments
Open

Implement text-fragments (with sufficient privacy protections) #22906

pes10k opened this issue May 17, 2022 · 3 comments
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/chromium-redqueen Work to remove privacy-harming "features" added in Chromium. privacy

Comments

@pes10k
Copy link
Contributor

pes10k commented May 17, 2022

Chrome ships a feature called "Text Fragments" that allow for, effectively, automatically scrolling to text in the page. It seems useful, but has open and known privacy risks 1, 2.

Brave would like to implement, but we don't feel comfortable doing so as is. We should prompt users before respecting / scrolling to the text fragment, with browser-controlled UI asking something lilke:

Would you like to scroll to text "X" (if it exists)

1. Yes
2. No
[ ] Don't ask again for this site

If the user selects "yes", we should visibly scroll the user display to the text fragment (if it exists)

This would make it further difficult for the the linking page to use it to probe page contents, and significantly reduce the chance for user confusion / phisihing / credential stealing

@pes10k pes10k added OS/Android Fixes related to Android browser functionality OS/Desktop privacy privacy/chromium-redqueen Work to remove privacy-harming "features" added in Chromium. labels May 17, 2022
@bsclifton bsclifton added this to Backlog in Android General via automation May 17, 2022
@bsclifton
Copy link
Member

cc: @rebron @anthonypkeane

@rebron rebron added this to P4 backlog in Front End May 31, 2022
@rebron rebron added this to Untriaged Backlog in General May 31, 2022
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label May 31, 2022
@rebron rebron moved this from Untriaged Backlog to P4 Backlog in General May 31, 2022
@ghost
Copy link

ghost commented Jun 18, 2022

@pes10k @bsclifton Hi all! I thought of this idea here: WICG/scroll-to-text-fragment#187

@psifertex
Copy link

psifertex commented Mar 20, 2024

None of this (Edit to add "this" being the security concerns in other related issues) seems like they would be blockers to creating links using this specification however? I frequently use this feature to send specific links to others, most of whom it will work for as they're not running brave.

I don't see why any security concerns on rendering such links would necessarily block the creation of them. Is there a different issue I'm missing that explains why that's the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/chromium-redqueen Work to remove privacy-harming "features" added in Chromium. privacy
Projects
Android General
  
Backlog
Front End
  
P4 backlog
General
  
P4 Backlog
Development

No branches or pull requests

4 participants