Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Asset Balances to taker asset dropdown on swaps #23161

Closed
HEagle18 opened this issue May 31, 2022 · 1 comment · Fixed by brave/brave-core#15762
Closed

Add Asset Balances to taker asset dropdown on swaps #23161

HEagle18 opened this issue May 31, 2022 · 1 comment · Fixed by brave/brave-core#15762
Assignees
Labels
feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include

Comments

@HEagle18
Copy link

Description

I want to see the balances of assets I have in my account when I select the dropdown on 'swap to'.

Steps to Reproduce

  1. Try do a swap with your wallet connected
  2. pick your 'from' asset
  3. then go to select your 'to' asset from dropdown

Actual result:

Expected result:

See screenshot attached from Matcha.
Screenshot 2022-05-31 at 17 07 48

Reproduces how often:

yes easy to reproduce. Try do a swap with your wallet connected, pick your 'from' asset and then go to select your 'to' asset from dropdown. We would like to see your balances listed beside these assets.

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Does the issue resolve itself when disabling Brave Rewards? no
  • Is the issue reproducible on the latest version of Chrome? yes

Miscellaneous Information:

@HEagle18 HEagle18 added priority/P4 Planned work. We expect to get to it "soon". OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/wallet/swap labels May 31, 2022
@HEagle18 HEagle18 changed the title Add Asset Balances to 'to' dropdown on swaps Add Asset Balances to taker asset dropdown on swaps May 31, 2022
@HEagle18 HEagle18 added the front-end-change This task is a front end task and doesn't need any C++ changes label May 31, 2022
@jamesmudgett jamesmudgett added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Jun 7, 2022
@onyb onyb self-assigned this Nov 9, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Nov 28, 2022
@onyb onyb added QA/Yes release-notes/include and removed OS/Android Fixes related to Android browser functionality labels Nov 28, 2022
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Jan 10, 2023
@srirambv
Copy link
Contributor

Verified as part of #26632 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/swap feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants