Sync Nightly code causes failure on Beta and Stable

[AlexeyBarabash]

Description

Time-limited sync code words from current Nightly (1.41.x) when are entered into Beta (1.40.x) or Stable (1.39.x) causes Error: GenerateCryptoErrorsForTypes@components/sync/driver/data_type_manager_impl.cc:35, cryptographer error was encountered:

Steps to Reproduce

1. Take Nightly browser (1.41.x)
2. Create a sync chain, copy sync code for desktop into clipboard
3. Take Beta (1.40.x)
4. Join the sync chain with words from the clipboard

Actual result:

Device list is empty

sync-internals page has error messages

Expected result:

It should be error displayed after attempt to reach the sync chain.

Reproduces how often:

Easily

Brave version (brave://version info)

Brave	1.40.80 Chromium: 102.0.5005.78 (Official Build) unknown (64-bit)
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? No

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

[kjozwiak]

This was a desktop specific fix but we should verify/ensure that restoring a new time-based sync code that's 25 words fails on 1.40.x which doesn't include brave/brave-core#12300. @brave/qa-team some more context/STR can be found via brave/brave-core#13574 (comment). Please ping me if anyone has any questions re: QA.

[kjozwiak]

Closing as brave/brave-core#13574 was merged into 1.40.x. The above will require 1.40.87 or higher for 1.40.x verification 👍

[stephendonner]

Verified PASSED using

Brave	1.40.87 Chromium: 102.0.5005.78 (Official Build) beta (x86_64)
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	macOS Version 11.6.6 (Build 20G624)

and

Brave	1.41.42 Chromium: 102.0.5005.78 (Official Build) nightly (x86_64)
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	macOS Version 11.6.6 (Build 20G624)

Steps:

1. installed 1.40.87 (beta) and 1.41.42 (nightly)
2. launched Brave nightly
3. opened brave://sync
4. clicked on Start a new Sync Chain (25-word count)
5. copied Sync code
6. launched Brave beta
7. opened brave://sync
8. clicked on I have a Sync Code
9. pasted the Sync code from nightly
10. clicked on Confirm
11. clicked on OK

Confirmed I saw the Invalid sync code, please check and try again. error message on the Enter a sync code dialog

nightly sync code	brave://sync (confirm)	brave://sync (OK)	error message	brave://sync-internals

[MadhaviSeelam]

Verification PASSED using

Brave	1.41.42 Chromium: 102.0.5005.78 (Official Build) nightly (64-bit) 
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	Windows 11 Version 21H2 (Build 22000.675)

and

Brave	1.40.87 Chromium: 102.0.5005.78 (Official Build) beta (64-bit) 
Revision	df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS	Windows 11 Version 21H2 (Build 22000.675)

Steps:

1. installed 1.40.87 (beta) and 1.41.42 (nightly)
2. launched Brave nightly
3. opened brave://sync
4. clicked on Start a new Sync Chain (25-word count)
5. copied Sync code
6. launched Brave beta
7. opened brave://sync
8. clicked on I have a Sync Code
9. pasted the Sync code from nightly
10. clicked on Confirm
11. clicked on OK

Confirmed I saw the Invalid sync code, please check and try again. error message on the Enter a sync code dialog

nightly sync code	brave://sync (confirm)	brave://sync (OK)	error message	brave://sync-internals

[Uni-verse]

Verified on Samsung Galaxy S21 5G & Tab S7 using

Brave	1.40.96 Chromium: 102.0.5005.115 (Official Build) beta (64-bit) 
Revision	174dbe6e33bc81994fceb71d751be201d0b4803d-refs/branch-heads/5005_109@{#3}
OS	Android 12; Build/SP1A.210812.016

Brave | 1.41.59 Chromium: 103.0.5060.42 (Official Build) nightly (x86_64)
-- | --
Revision | de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS | macOS Version 12.3.1 (Build 21E258)

STR - #23206 (comment)

• Confirmed sync error message is displayed when joining sync chain generated by nightly release that contains 25 word sync code by entering the code words.
• Confirmed sync fails and displays error message on Android ARM using sync code from Nightly Desktop.
• Confirmed sync fails and displays error message on Android ARM using sync code from Nightly build on mobile.
• User is able to dismiss sync error message
• Ensured user is still able to join sync chain after sync failing using the 25 word code.

Mobile	Tablet