Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DApps: Add decrypt request screen #23260

Closed
SergeyZhukovsky opened this issue Jun 6, 2022 · 3 comments · Fixed by brave/brave-core#13868
Closed

DApps: Add decrypt request screen #23260

SergeyZhukovsky opened this issue Jun 6, 2022 · 3 comments · Fixed by brave/brave-core#13868
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Blocked QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.41.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

Use skiff.org to test it.
@SergeyZhukovsky SergeyZhukovsky added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/dapps labels Jun 6, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Jun 9, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jun 20, 2022
Merged
25 tasks
This was referenced Jun 21, 2022
Merged
Closed
@Pavneet-Sing Pavneet-Sing added this to the 1.42.x - Nightly milestone Jun 22, 2022
@kjozwiak kjozwiak added QA/Yes and removed QA/No labels Jun 22, 2022
@kjozwiak
Copy link
Member

The above will require 1.41.77 or higher for 1.41.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Jun 29, 2022 •
edited
Loading

Blocked on #23769

Not blocked any more

@srirambv
Copy link
Contributor

srirambv commented Jul 5, 2022

Verification passed on the following devices running 1.41.91

  • Verified Decrypt request screen is shown and able to view the decrypted message
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
23260-ARM.mp4
23260-Tab.mp4

@kjozwiak kjozwiak mentioned this issue Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Blocked QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): implement DApps decrypt screen brave/brave-core
4 participants
@kjozwiak @Pavneet-Sing @SergeyZhukovsky @srirambv