Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for user to edit asset settings from asset view #23353

Open
HEagle18 opened this issue Jun 9, 2022 · 2 comments
Open

Add ability for user to edit asset settings from asset view #23353

HEagle18 opened this issue Jun 9, 2022 · 2 comments
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop

Comments

@HEagle18
Copy link

HEagle18 commented Jun 9, 2022

Description

After adding a custom asset, user doesn't have the ability to edit asset settings after.

Steps to Reproduce

  1. add a new asset to solana chain, like Bonfida
  2. then try edit details from asset view

Actual result:

Expected result:

Reproduces how often:

always

Brave version (brave://version info)

all versions

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N
  • Does the issue resolve itself when disabling Brave Rewards? N
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

https://community.brave.com/t/wallet-asset-token-management-ordering-view/399725 issue originated from this ticket

@HEagle18 HEagle18 added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jun 9, 2022
@jamesmudgett jamesmudgett added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jun 17, 2022
@muliswilliam
Copy link

@kleantzogu Please provide some design mock ups. They will be very similar to editing NFTs

@josheleonard
Copy link

josheleonard commented Jul 18, 2024

We have this feature for fungible assets, just need to add the same for NFTs in the details screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop
Projects
Status: Backlog
Development

No branches or pull requests

4 participants