Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fetch Payout Status #23429

Closed
Miyayes opened this issue Jun 13, 2022 · 2 comments · Fixed by brave/brave-core#14063
Closed

Implement fetch Payout Status #23429

Miyayes opened this issue Jun 13, 2022 · 2 comments · Fixed by brave/brave-core#14063
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android Tab QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Jun 13, 2022

Description

Fetch payout status from endpoint and dynamically show relevant UI/UX to user regarding the status of the ads payout. This will replace the current payout status UI/UX which is hardcoded.

See https://github.com/brave/internal/issues/882.

Server side: brave-intl/bat-go#1456

@Miyayes Miyayes added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 13, 2022
@Miyayes Miyayes added this to New Issues in Brave Rewards via automation Jun 13, 2022
@Miyayes Miyayes moved this from New Issues to On deck in Brave Rewards Jun 15, 2022
@emerick emerick moved this from On deck to In progress in Brave Rewards Jun 17, 2022
Brave Rewards automation moved this from In progress to Done Jul 11, 2022
@emerick emerick added this to the 1.43.x - Nightly milestone Jul 11, 2022
@emerick emerick added the QA/Yes label Jul 13, 2022
@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 11, 2022
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 16, 2022

Verification PASSED on

Brave | 1.43.71 Chromium: 104.0.5112.81 (Official Build) beta (64-bit)
-- | --
Revision | 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS | Windows 10 Version 21H2 (Build 19044.1889)

Verification notes are added in https://github.com/brave/internal/issues/882#issuecomment-1213412412


Verification is inprogress on Samsung Galaxy Tab A7 version 11 running Bravemonoarm64.apk_1.43.67

Verification notes are added in https://github.com/brave/internal/issues/882#issuecomment-1213415718

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 17, 2022
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 25, 2022
@LaurenWags
Copy link
Member

LaurenWags commented Aug 25, 2022

Verified with

Brave | 1.43.81 Chromium: 104.0.5112.102 (Official Build) (x86_64)
-- | --
Revision | 8e5396254975ef939f2ef7d0bd334e48a052b536-refs/branch-heads/5112@{#1478}
OS | macOS Version 12.5.1 (Build 21G83)

Per discussion with @GeetaSarvadnya - spot checking various scenarios.

See verification notes under https://github.com/brave/internal/issues/882#issuecomment-1227251327

Logged follow up issue #24980, additional testing to be done when follow up issue is retested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android Tab QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants