Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hackerone] wallet API freezing issue #23973

Closed
diracdeltas opened this issue Jul 11, 2022 · 2 comments · Fixed by brave/brave-core#14193
Closed

[hackerone] wallet API freezing issue #23973

diracdeltas opened this issue Jul 11, 2022 · 2 comments · Fixed by brave/brave-core#14193
Assignees
@darkdh
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include security
Milestone
1.42.x - Release

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Jul 11, 2022 •
edited

https://hackerone.com/reports/1631867

credit:
jordaaash
@diracdeltas diracdeltas added security priority/P2 A bad problem. We might uplift this to the next planned release. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Jul 11, 2022
@diracdeltas diracdeltas assigned diracdeltas and darkdh and unassigned diracdeltas Jul 12, 2022
@darkdh darkdh mentioned this issue Jul 14, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 17, 2022
@darkdh darkdh mentioned this issue Jul 22, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.42.81 or higher for 1.42.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Aug 1, 2022

Verification passed on

Brave 1.42.81 Chromium: 104.0.5112.69 (Official Build) (64-bit)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS Linux
  • Verified steps from issue description
  • Verified permission prompt is shown instead of logging the value
23973.mp4

Verification passed on

Brave 1.42.81 Chromium: 104.0.5112.69 (Official Build) (64-bit)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from issue description
  • Verified permission prompt is shown instead of logging the value
23973.mp4

Verification passed on

Brave 1.42.81 Chromium: 104.0.5112.69 (Official Build) (arm64)
Revision 7ce2902023c722af8564068e6b26e934b83fd774-refs/branch-heads/5112@{#1213}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from issue description
  • Verified permission prompt is shown instead of logging the value
23973.mov

@LaurenWags LaurenWags mentioned this issue Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

Freeze wallet provider API brave/brave-core
5 participants
@diracdeltas @kjozwiak @darkdh @srirambv @brave-builds