Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX follow-ups to top sites customization #6619 #24071

Closed
rebron opened this issue Jul 14, 2022 · 1 comment · Fixed by brave/brave-core#14197
Closed

UX follow-ups to top sites customization #6619 #24071

rebron opened this issue Jul 14, 2022 · 1 comment · Fixed by brave/brave-core#14197
Assignees
Labels

Comments

@rebron
Copy link
Collaborator

rebron commented Jul 14, 2022

Description

As a follow-up to top sites pagination #6619 :

  1. Remove the 1 "dot"/page enumeration until user creates a second page (or more than 12 top sites). Looks like a floating dot with only six tiles.
  2. With Brave News on, selecting the second "page" or second set of top sites makes Brave News peek up even more.
  3. When selecting a page 1, 2, 3, or 4 in top sites, opening a new tab page should keep you on the page you selected. For example, select page 3 on the existing new tab page. Open a new tab page, and top sites should remain on page 3. If a user has multiple new tab pages open, a change in one should not reflect in the others. Only a new tab should reflect the last selected pagination state.

Steps to Reproduce

See above. Using 1.43.20 and higher. To reproduce 1, need 12 top sites. To reproduce 2 and 3 requires 12 to 36 top sites. Can pick sites from here https://www.visualcapitalist.com/the-50-most-visited-websites-in-the-world/ or choice websites.

Actual result:

Screenshot 2022-07-14 at 4 08 11 PM

screenshot_2022-07-14_at_10 28 17_am

  1. Dot shown on one page.
  2. Brave News peeks higher with selection of page 2.
  3. Opening a new tab page always shows the first set of tiles or first page versus last viewed.

Expected result:

  1. No dot with first page/first set of six sites.
  2. No movement with Brave News with selection of pagination with top sites.
  3. Show last viewed page on opening of a new tab page.

Reproduces how often:

Easily.

Brave version (brave://version info)

1.43.20 and higer

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

@rebron rebron added feature/new-tab priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Jul 14, 2022
@rebron rebron added this to In progress in New Tab page Jul 15, 2022
@brave-builds brave-builds added this to the 1.43.x - Nightly milestone Jul 17, 2022
@rebron rebron moved this from In progress to Completed in New Tab page Jul 18, 2022
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 15, 2022
@stephendonner
Copy link
Collaborator

stephendonner commented Aug 15, 2022

Verified PASSED using

Brave 1.43.70 Chromium: 104.0.5112.81 (Official Build) beta (x86_64)
Revision 5b7b76419d50f583022568b6764b630f6ddc9208-refs/branch-heads/5112@{#1309}
OS macOS Version 11.6.8 (Build 20G730)

1. Confirmed no pagination dots (o) until 12+ tiles:

No pagination (11 tiles) Pagination (12+ tiles)
Screen Shot 2022-08-15 at 4 25 06 PM Screen Shot 2022-08-15 at 4 29 55 PM

2. Confirmed no Brave News "peeking" movement when switching between pages:

example example example
Screen Shot 2022-08-15 at 4 36 18 PM Screen Shot 2022-08-15 at 4 39 33 PM Screen Shot 2022-08-15 at 4 40 09 PM

3. Confirmed retained selected page # when opening new tabs

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
New Tab page
Completed
Development

Successfully merging a pull request may close this issue.

4 participants