Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debouncer doesn't work in a fresh profile #24087

Open
fmarier opened this issue Jul 16, 2022 · 10 comments
Open

Debouncer doesn't work in a fresh profile #24087

fmarier opened this issue Jul 16, 2022 · 10 comments
Labels
OS/Desktop privacy/debounce URL debouncer privacy/discussed Discussed in privacy confab privacy

Comments

@fmarier
Copy link
Member

fmarier commented Jul 16, 2022

Description

The debouncer doesn't work in a new profile. Maybe it doesn't know how to reload the debounce.json file once it becomes available?

Steps to Reproduce

  1. Create a fresh browser profile and start the browser.
  2. Visit https://dev-pages.brave.software/navigation-tracking/debouncing.html
  3. Close the browser and start it again in the same profile.
  4. Visit https://dev-pages.brave.software/navigation-tracking/debouncing.html

Actual result:

Step 2:
Screenshot from 2022-07-15 17-37-15

Step 4:
Screenshot from 2022-07-15 17-36-46

Expected result:

Both Step 2 and Step 4:
Screenshot from 2022-07-15 17-36-46

Reproduces how often:

Always.

Brave version (brave://version info)

Brave | 1.43.23 Chromium: 103.0.5060.114 (Official Build) nightly (64-bit)
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Linux

@fmarier
Copy link
Member Author

fmarier commented Jul 18, 2022

cc @bridiver who may have encountered this while testing/working on #24080

@bridiver
Copy link
Contributor

This is normal and expected because debounce is enabled by griffin so it doesn't take affect on the first load.

@bridiver
Copy link
Contributor

sorry, missed that you restarted. @pes10k ?

@pes10k
Copy link
Contributor

pes10k commented Jul 18, 2022

Hmm, worked fine for me on restart. We should get the feature enabled by default too; otherwise we're shipping folks an increasingly broken browser on first start (will move the second part to slack)

@ShivanKaul ShivanKaul added the privacy/discussed Discussed in privacy confab label Jul 19, 2022
@fmarier
Copy link
Member Author

fmarier commented Nov 7, 2022

I think we fixed this, right @pes10k ? The debouncer is enabled by default now?

@pes10k
Copy link
Contributor

pes10k commented Nov 7, 2022

cc @pilgrim-brave

@pilgrim-brave
Copy link

The debounce code is enabled by default (in a brave://flags sense), but there are no debouncing rules until Brave downloads debounce.json as part of the Local Data Files component.

@pes10k
Copy link
Contributor

pes10k commented Nov 7, 2022

just noting that this isn't a special case for debouncer; its true for adblock-rs filtering and many other component served things. So i think its probably good to fix (basically freeze up Brave until the first round of components have been fetched) but we should have a general solution to it, not something debouncer-specific

@bridiver
Copy link
Contributor

bridiver commented Nov 7, 2022

just noting that this isn't a special case for debouncer; its true for adblock-rs filtering and many other component served things. So i think its probably good to fix (basically freeze up Brave until the first round of components have been fetched) but we should have a general solution to it, not something debouncer-specific

I suggested this to @bbondy a long time ago, but depending on connection speed it has the potential to make Brave look very slow on the first startup which is not great. Another option would be to bundle whatever the current rules are at CI build time.

@pes10k
Copy link
Contributor

pes10k commented Nov 7, 2022

i think that is a great idea (bundling the then-current version of components with the builds)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop privacy/debounce URL debouncer privacy/discussed Discussed in privacy confab privacy
Projects
None yet
Development

No branches or pull requests

5 participants