New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debouncer doesn't work in a fresh profile #24087
Comments
This is normal and expected because debounce is enabled by griffin so it doesn't take affect on the first load. |
sorry, missed that you restarted. @pes10k ? |
Hmm, worked fine for me on restart. We should get the feature enabled by default too; otherwise we're shipping folks an increasingly broken browser on first start (will move the second part to slack) |
I think we fixed this, right @pes10k ? The debouncer is enabled by default now? |
The debounce code is enabled by default (in a |
just noting that this isn't a special case for debouncer; its true for adblock-rs filtering and many other component served things. So i think its probably good to fix (basically freeze up Brave until the first round of components have been fetched) but we should have a general solution to it, not something debouncer-specific |
I suggested this to @bbondy a long time ago, but depending on connection speed it has the potential to make Brave look very slow on the first startup which is not great. Another option would be to bundle whatever the current rules are at CI build time. |
i think that is a great idea (bundling the then-current version of components with the builds) |
Description
The debouncer doesn't work in a new profile. Maybe it doesn't know how to reload the
debounce.json
file once it becomes available?Steps to Reproduce
Actual result:
Step 2:
Step 4:
Expected result:
Both Step 2 and Step 4:
Reproduces how often:
Always.
Brave version (brave://version info)
The text was updated successfully, but these errors were encountered: