Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User issue: SOL quantity multiplied by 10 in confirmation screen #24109

Closed
hollons opened this issue Jul 18, 2022 · 2 comments · Fixed by brave/brave-core#14219
Closed

User issue: SOL quantity multiplied by 10 in confirmation screen #24109

hollons opened this issue Jul 18, 2022 · 2 comments · Fixed by brave/brave-core#14219
Assignees
@Douglashdaniel
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.41.x - Release #2

Comments

@hollons
Copy link

hollons commented Jul 18, 2022

No description provided.

@hollons hollons transferred this issue from brave/brave-wallet-docs Jul 18, 2022
@hollons hollons assigned hollons and Douglashdaniel and unassigned hollons Jul 18, 2022
@hollons hollons added the feature/web3/wallet Integrating Ethereum+ wallet support label Jul 18, 2022
@hollons
Copy link
Author

hollons commented Jul 18, 2022 •
edited

A user reported that "when supplying an amount of SOL on Solend.fi with the Brave Wallet, the quantity is automatically multiplied by 10 on the confirmation screen." Here's the post for additional context - https://community.brave.com/t/brave-wallet-bug-with-solend-fi/415645/2.

Screen Shot

@Douglashdaniel Douglashdaniel added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/solana labels Jul 18, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Jul 18, 2022
Merged
25 tasks
@kjozwiak kjozwiak added this to the 1.41.x - Release #2 milestone Jul 20, 2022
@srirambv
Copy link
Contributor

Brave 1.41.99 Chromium: 103.0.5060.134 (Official Build) (64-bit)
Revision 8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#14219
  • Verified Dapp tx amount is shown correctly even for decimal values
24109-Linux.mp4
24109-Windows.mp4
24109-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.41.x - Release #2
Development

Successfully merging a pull request may close this issue.

fix(wallet): Solana 10x dApp Tx Amount brave/brave-core
4 participants
@kjozwiak @srirambv @hollons @Douglashdaniel