Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solana: Pending request for Devnet is not shown and show pending requests for default networks #24410

Closed
2 tasks done
Pavneet-Sing opened this issue Aug 3, 2022 · 1 comment · Fixed by brave/brave-core#14497
Closed
2 tasks done

Solana: Pending request for Devnet is not shown and show pending requests for default networks #24410

Pavneet-Sing opened this issue Aug 3, 2022 · 1 comment · Fixed by brave/brave-core#14497
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Android General
Milestone
1.44.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Aug 3, 2022 •
edited

Description

  • Show Solana pending request first time
  • Show pending requests for default networks in dapps panel until 24384 issue is done to fetch the corresponding network
solana-request.mp4
@Pavneet-Sing Pavneet-Sing added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/solana labels Aug 3, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Aug 3, 2022
@Pavneet-Sing Pavneet-Sing added this to Backlog in Android General via automation Aug 3, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Aug 5, 2022
Merged
25 tasks
Android General automation moved this from Backlog to Done/Closed Aug 8, 2022
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 8, 2022
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.44.79 x64 Beta build

  • Verified steps from brave/brave-core#14497
  • Verified pending request is show for Solana account transactions via the bell icon in portfolio
  • Verified able to submit the transaction from pending requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Web3
Archived in project
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): show default network tx brave/brave-core
4 participants
@kjozwiak @Pavneet-Sing @srirambv @brave-builds