Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include mobile app annoyances by default #24506

Closed
ryanbr opened this issue Aug 7, 2022 · 2 comments · Fixed by brave/brave-core#16570
Closed

Include mobile app annoyances by default #24506

ryanbr opened this issue Aug 7, 2022 · 2 comments · Fixed by brave/brave-core#16570
Assignees
Labels
feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA/No release-notes/include

Comments

@ryanbr
Copy link

ryanbr commented Aug 7, 2022

Description

Include mobile app annoyances/popups by default (Android and possibly IOS)

download-mobi

With https://www.macrumors.com/2022/08/05/ios-app-blocks-annoying-pop-ups-in-safari/ being offered we can do something similar also in Brave

List currently being offered:

https://github.com/easylist/easylist/blob/master/fanboy-addon/fanboy_notifications_specific_hide.txt#L66
https://github.com/easylist/easylist/blob/master/fanboy-addon/fanboy_annoyance_specific_uBO.txt#L6

Convert some Adguard specific filters

Needing to investigate (and convert, remove any procedural filters) additions from Adguard:

https://github.com/AdguardTeam/AdguardFilters/blob/master/AnnoyancesFilter/MobileApp/sections/mobile-app_specific.txt
https://github.com/AdguardTeam/AdguardFilters/tree/master/AnnoyancesFilter/MobileApp/sections

Possible issues that need to be avoided

  • Removing legit content
  • Scroll blocked
  • Missed lightbox overlays
  • Multiple scrolls

IOS support?

Various Cosmetic filtering, :style and removeclass would be needed to be supported on IOS

Miscellaneous Information:

No ETA, Needs reviewing and testing and avoid website breakages (overlays or scroll blocks, multiple scrolls)

@ryanbr ryanbr added feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality labels Aug 7, 2022
@ryanbr ryanbr self-assigned this Aug 7, 2022
@ryanbr ryanbr added this to To do in Web Compatibility via automation Aug 7, 2022
@ryanbr
Copy link
Author

ryanbr commented Aug 7, 2022

Separating off mobile app notifications from other notifications is another goal here

@LaurenWags
Copy link
Member

Per discussion with @rebron not going to include in desktop release notes but it should be included in Android/iOS notes. Also, leaving OS/Desktop as code is technically in desktop per discussion with @antonok-edm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality QA/No release-notes/include
Projects
Development

Successfully merging a pull request may close this issue.

4 participants