Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show full network name in Network selector (BRA-Q322-3. Misleading Blockchain Names) #25114

Closed
josheleonard opened this issue Aug 31, 2022 · 1 comment · Fixed by brave/brave-core#14979
Closed

Show full network name in Network selector (BRA-Q322-3. Misleading Blockchain Names) #25114

josheleonard opened this issue Aug 31, 2022 · 1 comment · Fixed by brave/brave-core#14979
Assignees
@josheleonard
Labels
design A design change, especially one which needs input from the design team feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Milestone
1.45.x - Release

Comments

@josheleonard
Copy link
Collaborator

Description

BRA-Q322-3. Misleading Blockchain Names

Before rendering a blockchain name, Brave Wallet uses the reduceNetworkDisplayName function to reduce the network name.
Such a design decision leads to ambiguity for users and possible unintended transactions. For example, executing transaction on the main network instead of using test network. Users must hover over the blockchain name to be sure on which network they will be executing transactions.

Steps to Reproduce

  1. Enable displaying test networks from Wallet setting
  2. Unlock the desktop version of the Brave Wallet
  3. Select Solana Testnet
  4. Notice that the selected network name is not fully displayed

Actual result:

Network name reads "Solana"

Expected result:

Network name reads "Solana Testnet"

Reproduces how often:

Easy
@josheleonard josheleonard self-assigned this Aug 31, 2022
@josheleonard josheleonard added design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. front-end-change This task is a front end task and doesn't need any C++ changes and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Aug 31, 2022
@josheleonard josheleonard mentioned this issue Sep 2, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Sep 6, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 28, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Linux
  • Verified steps from brave/brave-core#14979
  • Verified full network name is shown on both panel and widget
  • Verified after connecting to Dapp network full name is shown
  • Verified full network name is shown on the network dropdown list
14979.mp4

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from brave/brave-core#14979
  • Verified full network name is shown on both panel and widget
  • Verified after connecting to Dapp network full name is shown
  • Verified full network name is shown on the network dropdown list
14979.mp4

Verification passed on

Brave 1.45.95 Chromium: 106.0.5249.103 (Official Build) beta (arm64)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS macOS Version 12.6 (Build 21G115)
  • Verified steps from brave/brave-core#14979
  • Verified full network name is shown on both panel and widget
  • Verified after connecting to Dapp network full name is shown
  • Verified full network name is shown on the network dropdown list
14979.mov

@srirambv srirambv mentioned this issue Oct 14, 2022
Closed
@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
design A design change, especially one which needs input from the design team feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

Fix show full network name in network selector brave/brave-core
4 participants
@srirambv @LaurenWags @josheleonard @brave-builds