Removing a device from sync chain doesn't remove it from devices list

[srirambv]

Description

Removing a device from sync chain doesn't remove it from devices list

Steps to Reproduce

1. Install 0.58.12 and 0.59.6
2. Enable Sync on 0.58.12 and copy code to 0.59.6
3. Ensure both devices are listed on both versions under sync
4. Remove second device from 0.58.12

Actual result:

https://drive.google.com/open?id=1pRap44wpQjWFTWXJ6tZIJRtV2rgz9ecZ

Expected result:

Should remove the device from the list after its removed from sync chain

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Linux

Brave	0.59.6 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Linux

Reproducible on current release:

• Does it reproduce on brave-browser dev/beta builds?

Website problems only:

• Does the issue resolve itself when disabling Brave Shields?
• Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @cezaraugusto @brave/legacy_qa to verify on other platfroms
Not a serious bug that release needs to be blocked on this @rebron @bbondy

[darkdh]

please do not test with different channels.
the usage of --user-data-dir is shared through DM

[darkdh]

@cezaraugusto we need to prevent user from clicking remove multiple times(sending duplicated delete record) while delete record is sending under the hood

[darkdh]

@cezaraugusto we also need to dismiss the remove modal when user click "Remove"
considering this

1. Have 3 devices in sync chain: A, B, C
2. Remove C from A
3. You can notice the device list on A contains only two devices but the modal is still there

[darkdh]

move above front end issues to #2629
This issue will be closed by brave/brave-core#1135 which addresses the root cause

[GeetaSarvadnya]

Verification passed on

Brave	0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision	08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS	Windows

• Verified the STR mentioned in the issue
• Verified the test plan mentioned in Prevent duplicate nodes from reconnect and refine reset to make sure deleted record is sent brave-core#1135
  step 7 fails, unable to connect devices (A and B) with old /new code word. Logged new issue Re-sync is not successful with new secrete code (Follow up of #2552) #2737

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

• Verified the STR mentioned in the issue
• Verified the test plan mentioned in Prevent duplicate nodes from reconnect and refine reset to make sure deleted record is sent brave-core#1135

Verified passed with

Brave	0.59.18 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Mac OS X

• Verified STR in description
• Verified test plan from Prevent duplicate nodes from reconnect and refine reset to make sure deleted record is sent brave-core#1135