Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Virtualized tokens list in portfolio page #25565

Closed
josheleonard opened this issue Sep 22, 2022 · 2 comments · Fixed by brave/brave-core#15181
Closed

Revert Virtualized tokens list in portfolio page #25565

josheleonard opened this issue Sep 22, 2022 · 2 comments · Fixed by brave/brave-core#15181
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.45.x - Release

Comments

@josheleonard
Copy link

Removing the virtualized tokens list from the portfolio page (performance experiment). The list items will now render within the main page body and utilize the main page scrollbar.

Actual result:

Screen.Recording.2022-09-22.at.12.34.15.PM.mov

Expected result:

Screen.Recording.2022-09-22.at.12.23.03.PM.mov
@josheleonard josheleonard added QA/Yes release-notes/include OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Sep 22, 2022
@josheleonard josheleonard self-assigned this Sep 22, 2022
@josheleonard josheleonard mentioned this issue Sep 22, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Sep 23, 2022
@brave-builds brave-builds mentioned this issue Sep 26, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.45.77 or higher for 1.45.x verification 👍

@kjozwiak kjozwiak added the feature/web3/wallet Integrating Ethereum+ wallet support label Sep 29, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (64-bit)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS Linux
  • Verified steps from brave/brave-core#15181
  • Verified the entire page is scrollable instead of just the token list

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (64-bit)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS Windows 11 Version 22H2 (Build 22621.674)
  • Verified steps from brave/brave-core#15181
  • Verified the entire page is scrollable instead of just the token list

Verification passed on

Brave 1.45.104 Chromium: 106.0.5249.126 (Official Build) beta (arm64)
Revision fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#15181
  • Verified the entire page is scrollable instead of just the token list

@LaurenWags LaurenWags mentioned this issue Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.45.x - Release
Development

Successfully merging a pull request may close this issue.

fix: revert portfolio page virtualized tokens list brave/brave-core
4 participants
@kjozwiak @srirambv @josheleonard @brave-builds