Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use backend instruction data decoder rather than solana-web3 lib in desktop frontend #25681

Closed
yrliou opened this issue Sep 28, 2022 · 1 comment · Fixed by brave/brave-core#17128
Assignees
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@yrliou
Copy link
Member

yrliou commented Sep 28, 2022

brave/brave-core#15142 implement a backend decoder with support of System and Token program.
We should revise our frontend to use this instead of having deps of solana-web3 in brave_wallet_ui component.
Note that currently our frontend uses solana-web3 and supports System, Staking, and Vote program, by switching to the backend decoder result, we will not have Staking and Vote program support for now but will have Token program support added.
cc @Douglashdaniel

@yrliou yrliou added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes feature/web3/wallet/solana labels Sep 28, 2022
@Douglashdaniel Douglashdaniel self-assigned this Sep 29, 2022
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 22, 2023
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Linux
  • Verified steps from brave/brave-core#17128
  • Verified Transaction parameters (addresses and amount) are shown for Sign and Send Transaction System Program
  • Verified Transaction parameters (addresses and amount) are shown for Sign and Send SPL Transaction Token Program
  • Verified Raw Transaction info is shown for non-decodable instructions (program id and data)
25681.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS Windows 11 Version 22H2 (Build 22621.1344)
  • Verified steps from brave/brave-core#17128
  • Verified Transaction parameters (addresses and amount) are shown for Sign and Send Transaction System Program
  • Verified Transaction parameters (addresses and amount) are shown for Sign and Send SPL Transaction Token Program
  • Verified Raw Transaction info is shown for non-decodable instructions (program id and data)
25681.mp4

Verification passed on

Brave 1.50.93 Chromium: 111.0.5563.64 (Official Build) beta (arm64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#17128
  • Verified Transaction parameters (addresses and amount) are shown for Sign and Send Transaction System Program
  • Verified Transaction parameters (addresses and amount) are shown for Sign and Send SPL Transaction Token Program
  • Verified Raw Transaction info is shown for non-decodable instructions (program id and data)
25681.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants