Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This Device is put on the wrong row #2572

Closed
darkdh opened this issue Dec 14, 2018 · 2 comments · Fixed by brave/brave-core#1100
Closed

This Device is put on the wrong row #2572

darkdh opened this issue Dec 14, 2018 · 2 comments · Fixed by brave/brave-core#1100

Comments

@darkdh
Copy link
Member

darkdh commented Dec 14, 2018

Description

"This Device" is always be put on the row which id ==0

Steps to Reproduce

  1. Setup sync chain between device a and device b (click create sync chain on a and connect it on b)
  2. On the device table of both device a and b, this device always points to a

Actual result:

screen shot 2018-12-05 at 09 07 10

Expected result:

screen shot 2018-12-13 at 13 59 36

Reproduces how often:

100%

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@LaurenWags
Copy link
Member

Noticed this issue this morning on 0.58.12 on both my mac laptop and Linux VM. Both devices show the Mac as 'This Device':
screen shot 2018-12-14 at 9 43 41 am

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 25, 2018

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows
  • Verified the STR from description, This Device is displayed as expected.
    image

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

  • Verified the STR from description, This Device is displayed as expected.
    image

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

screen shot 2019-01-03 at 12 47 29 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment