Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons via autocomplete are misaligned #26063

Closed
kjozwiak opened this issue Oct 17, 2022 · 3 comments
Closed

icons via autocomplete are misaligned #26063

kjozwiak opened this issue Oct 17, 2022 · 3 comments

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Oct 17, 2022

Description

Sometimes the icons for websites/search suggestions appearing via autocomplete appear misaligned.

Steps to reproduce

  1. launch brave
  2. go into Hamburger menu -> Brave Shields & privacy
  3. enable Auto-complete searches and URLs & Show suggested sites in autocomplete
  4. start searching/visiting several websites to build a history

Eventually you'll notice that the icons are appearing misaligned as per the screenshot/example below.

Actual result

alignmentIssue

Expected result

Issue reproduces how often

It's pretty easy to reproduce but not 100% sure how often. I usually see it every time I start verification on Android.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? No
  • Can you reproduce this issue with the current Play Store Nightly version? No

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung S10+
  • Android version: Android 12

Brave version

Brave | 1.44.114 Chromium: 106.0.5249.126 (Official Build) (32-bit)
--- | ---
Revision | fb2e06d2dee20fe0c804528502b5ad72c613abd9-refs/branch-heads/5249_118@{#3}
OS | Android 12; Build/SP1A.210812.016

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

@kjozwiak
Copy link
Member Author

Looks like the above is fixed via 1.45.x as I can't reproduce the issue on 1.46.x & 1.45.x as per the following:

1.44.x 1.45.x 1.46.x
Screenshot_20221017-023544_Brave Screenshot_20221017-023014_Brave - Beta Screenshot_20221017-022604_Brave - Nightly

@deeppandya deeppandya added this to the 1.45.x - Release milestone Oct 19, 2022
@deeppandya
Copy link

it's fixed in 1.45.x.

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 & Samsung Galaxy Tab S7 using the following build(s):

Brave	1.45.109 Chromium: 107.0.5304.62 (Official Build) (64-bit) 
Revision	1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS	Android 12; Build/SP1A.210812.016

Use Case per #26063 (comment)

  1. launch brave
  2. go into Hamburger menu -> Brave Shields & privacy
  3. enable Auto-complete searches and URLs & Show suggested sites in autocomplete
  4. start searching/visiting several websites to build a history
  • Verified icons are aligned correctly in the search suggestions view
  • Verified icons are aligned in both portrait and landscape view
Example Example Example
screenshot-1666379500752 screenshot-1666379816171 screenshot-1666379513237

screenshot-1666379895861

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants