Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser crash on https://d3ward.github.io/toolz/adblock with enabled Ru Adlist #26075

Closed
atuchin-m opened this issue Oct 17, 2022 · 4 comments · Fixed by brave/brave-core#15578
Assignees
Labels
Projects

Comments

@atuchin-m
Copy link
Contributor

Description

Browser process crashes when open certain sites with enabled adblock list Ru Adlist.
Disabling Ru Adlist fixes the problem. Could be the same issue with some other additional adblock lists.

Steps to Reproduce

  1. Enable Ru Adlist on brave://adblock
  2. Open new tab and navigate to https://d3ward.github.io/toolz/adblock

Actual result:

Main process crashed.

Reproduces how often:

Always

Desktop Brave version:

1.46.56 Chromium: 106.0.5249.119 (Official Build) nightly (arm64)

Android Device details:

Doesn't check Android, but it uses the same code.

Version/Channel Information:

  • Can you reproduce this issue with the current release?
    Yes
  • Can you reproduce this issue with the beta channel?
    Yes
  • Can you reproduce this issue with the nightly channel?
    Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    Yes
  • Does the issue resolve itself when disabling Brave Rewards?
    No
  • Is the issue reproducible on the latest version of Chrome?
    No
@atuchin-m atuchin-m added crash OS/Android Fixes related to Android browser functionality OS/Desktop labels Oct 17, 2022
@antonok-edm antonok-edm self-assigned this Oct 17, 2022
@kjozwiak kjozwiak added this to Untriaged / Incoming in Shields via automation Oct 17, 2022
@kjozwiak kjozwiak added the feature/shields/adblock Blocking ads & trackers with Shields label Oct 17, 2022
@kjozwiak
Copy link
Member

@atuchin-m should try getting the above uplifted into 1.45.x if we fix it in time 👍 CCing @rebron

@kjozwiak
Copy link
Member

The above requires 1.46.80 or higher for 1.46.x verification 👍

@stephendonner
Copy link

Verified PASSED using

Brave 1.46.80 Chromium: 107.0.5304.68 (Official Build) beta (x86_64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 11.7.1 (Build 20G918)

First, confirmed the clean exit/crash using 1.46.56.

Steps:

  1. installed 1.46.80
  2. launched Brave
  3. opened brave://adblock
  4. checked RU Adlist
  5. loaded https://d3ward.github.io/toolz/adblock

Confirmed I was able to load https://d3ward.github.io/toolz/adblock with RU Adlist enabled, without crashing

brave://adblock https://d3ward.github.io/toolz/adblock
Screen Shot 2022-10-26 at 10 54 12 AM Screen Shot 2022-10-26 at 10 54 20 AM

@srirambv
Copy link
Contributor

srirambv commented Nov 2, 2022

Verification passed on Oppo Reno 5 with Android 12 running 1.46.87 x64 Beta build

  • Verified steps from issue description
  • Verified enabling Ru Adlist and loading https://d3ward.github.io/toolz/adblock doesn't cause any crash (browser/webview)
chrome://adblock https://d3ward.github.io/toolz/adblock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Shields
  
Completed
Development

Successfully merging a pull request may close this issue.

6 participants