Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cosmetic filtering] Disable checking for 1st party content in 3rd party frames #26212

Closed
antonok-edm opened this issue Oct 24, 2022 · 0 comments · Fixed by brave/brave-core#15633
Closed

[cosmetic filtering] Disable checking for 1st party content in 3rd party frames #26212

antonok-edm opened this issue Oct 24, 2022 · 0 comments · Fixed by brave/brave-core#15633
Assignees
@antonok-edm
Labels
feature/shields/adblock Blocking ads & trackers with Shields features/shields/cosmetic-filtering OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/include
Milestone
1.47.x - Release

Comments

@antonok-edm
Copy link
Collaborator

3rd party frames should always have the aggressive mode cosmetic filtering configuration applied. This should save some performance for sites with 3rd-party frames.
@antonok-edm antonok-edm added feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality features/shields/cosmetic-filtering OS/Desktop labels Oct 24, 2022
@antonok-edm antonok-edm self-assigned this Oct 24, 2022
@antonok-edm antonok-edm mentioned this issue Oct 24, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.47.x - Nightly milestone Oct 25, 2022
@LaurenWags LaurenWags mentioned this issue Jan 11, 2023
Closed
This was referenced Jan 12, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antonok-edm antonok-edm

Labels
feature/shields/adblock Blocking ads & trackers with Shields features/shields/cosmetic-filtering OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/include
Projects
None yet
Milestone
1.47.x - Release
Development

Successfully merging a pull request may close this issue.

Disable cosmetic filtering 1st-party checks in 3rd-party frames brave/brave-core
2 participants
@antonok-edm @brave-builds