Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto should be lowercase on Gemini and Binance widget previews #26223

Closed
stephendonner opened this issue Oct 24, 2022 · 7 comments · Fixed by brave/brave-core#15720
Closed

Comments

@stephendonner
Copy link

Description

Crypto should be lowercase on Gemini and Binance widget previews

Steps to Reproduce

  1. install 1.47.14
  2. launch Brave
  3. open a new-tab page
  4. click on Edit Cards
  5. look at the capitalization of Crypto for Gemini and Binance widget previews/summaries

Actual result:

Trade Crypto on... (upper-cased)

Screen Shot 2022-10-24 at 3 58 57 PM

Expected result:

Gemini
Trade crypto on Gemini directly in your browser.

Binance
Trade crypto on Binance directly in your browser.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.47.14 Chromium: 107.0.5304.62 (Official Build) nightly (x86_64)
Revision 1eec40d3a5764881c92085aaee66d25075c159aa-refs/branch-heads/5304@{#942}
OS macOS Version 11.7 (Build 20G817)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

/cc @jamesmudgett @srirambv @rebron @rmcfadden3

@stephendonner stephendonner added good first issue needs-text-change This change requires some careful wording. QA/Yes OS/Desktop labels Oct 24, 2022
@NaaeemMalik
Copy link
Contributor

Can I be assigned to it?

@yeshwantthota
Copy link

@NaaeemMalik are u working on the issue?

@NaaeemMalik
Copy link
Contributor

It's not been assigned to me so not yet

@NaaeemMalik
Copy link
Contributor

@yeshwantthota should I be working on it?

@yeshwantthota
Copy link

@NaaeemMalik if u want, then work on it and submit your PR

@NaaeemMalik
Copy link
Contributor

@yeshwantthota alright, I will work on it, thou I also waanna tell you that its gonna be my first open source coding bug although I have 8 years software development experience

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.47.39 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Screen Shot 2022-11-02 at 3 46 56 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants