Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a dedicated desktop page for wallet transactions #27106

Closed
josheleonard opened this issue Dec 1, 2022 · 1 comment · Fixed by brave/brave-core#16196
Closed

Create a dedicated desktop page for wallet transactions #27106

josheleonard opened this issue Dec 1, 2022 · 1 comment · Fixed by brave/brave-core#16196
Assignees
@josheleonard
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.48.x - Release

Comments

@josheleonard
Copy link
Collaborator

josheleonard commented Dec 1, 2022 •
edited

Description

Provide a screen located at /crypto/transactions for viewing transactions
@josheleonard josheleonard added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 1, 2022
@josheleonard josheleonard self-assigned this Dec 1, 2022
@josheleonard josheleonard mentioned this issue Dec 1, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 21, 2022
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Linux
  • Verified steps from brave/brave-core#16196
  • Verified a new tab for transactions is available
  • Verified when there are no transactions placeholder text is shown
  • Verifies submitted and completed transactions are listed
  • Verified transaction state is automatically updated
  • Verified able to search for transactions
27106.mp4

Verification passed on

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (64-bit)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16196
  • Verified a new tab for transactions is available
  • Verified when there are no transactions placeholder text is shown
  • Verifies submitted and completed transactions are listed
  • Verified transaction state is automatically updated
  • Verified able to search for transactions
27106.mp4

Verification passed on

Brave 1.48.141 Chromium: 109.0.5414.119 (Official Build) beta (arm64)
Revision 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16196
  • Verified a new tab for transactions is available
  • Verified when there are no transactions placeholder text is shown
  • Verifies submitted and completed transactions are listed
  • Verified transaction state is automatically updated
  • Verified able to search for transactions
27106.mov

@LaurenWags LaurenWags mentioned this issue Feb 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josheleonard josheleonard

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): dedicated aggregated transactions page brave/brave-core
3 participants
@srirambv @josheleonard @brave-builds