Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto discovering Solana assets #27246

Closed
yrliou opened this issue Dec 8, 2022 · 2 comments · Fixed by brave/brave-core#16530
Closed

Auto discovering Solana assets #27246

yrliou opened this issue Dec 8, 2022 · 2 comments · Fixed by brave/brave-core#16530
Assignees
@nvonpentz
Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Dec 8, 2022 •
edited
Loading

SPL tokens on the Brave Wallet token list will be automatically added to user’s portfolio when they have a positive balance.
Should be doable via:
https://docs.solana.com/developing/clients/jsonrpc-api#gettokenaccountsbyowner
@yrliou yrliou changed the title Auto discovery Solana assets Auto discovering Solana assets Dec 8, 2022
@yrliou yrliou added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support labels Dec 9, 2022
@nvonpentz nvonpentz mentioned this issue Jan 11, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 20, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.49.106 x64 Beta build

  • Verified steps from brave/brave-core#16530
  • Verified Solana assets are auto-discovered and listed
  • Verified Solana asset discovery works on importing an account via private key
  • Verified Solana asset discovery works on restoring a seed
  • Verified Solana asset discovery works when adding a new account
  • Verified on a new wallet it loads the default native token

Verification passed on Samsung Tab A with Android 10 running 1.49.106 x64 Beta build

  • Verified steps from brave/brave-core#16530
  • Verified Solana assets are auto-discovered and listed
  • Verified Solana asset discovery works on importing an account via private key
  • Verified Solana asset discovery works on restoring a seed
  • Verified Solana asset discovery works when adding a new account
  • Verified on a new wallet it loads the default native token

@yrliou yrliou mentioned this issue Feb 23, 2023
Open
15 tasks
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Linux
  • Verified steps from brave/brave-core#16530
  • Verified Solana assets are auto-discovered and listed
  • Verified Solana asset discovery works on importing an account via private key
  • Verified Solana asset discovery works on restoring a seed
  • Verified Solana asset discovery works when adding a new account
  • Verified on a new wallet it loads the default native token

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16530
  • Verified Solana assets are auto-discovered and listed
  • Verified Solana asset discovery works on importing an account via private key
  • Verified Solana asset discovery works on restoring a seed
  • Verified Solana asset discovery works when adding a new account
  • Verified on a new wallet it loads the default native token

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (arm64)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16530
  • Verified Solana assets are auto-discovered and listed
  • Verified Solana asset discovery works on importing an account via private key
  • Verified Solana asset discovery works on restoring a seed
  • Verified Solana asset discovery works when adding a new account
  • Verified on a new wallet it loads the default native token

@LaurenWags LaurenWags mentioned this issue Mar 8, 2023
Closed
This was referenced Mar 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvonpentz nvonpentz

Labels
feature/web3/wallet/core feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

Solana auto discovery brave/brave-core
4 participants
@yrliou @nvonpentz @srirambv @brave-builds