Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser showing blank space for displaying Brave Banner #2746

Closed
avndp opened this issue Dec 27, 2018 · 4 comments
Closed

Browser showing blank space for displaying Brave Banner #2746

avndp opened this issue Dec 27, 2018 · 4 comments

Comments

@avndp
Copy link

avndp commented Dec 27, 2018

Description

I have displayed a brave banner in my blog and linked it to brave with my referral link. When the shield is on, it is showing large blank space as shown in this snap: https://i.imgur.com/9CnXFw2.png , whereas the image size is only 728x90. Though it is a brave linked banner, it is still blocked and showing blank space beyond 90px height.

Steps to Reproduce

  1. Visit the URL: https://aavo.in/the-1st-best-screenshot-software-for-linux-ubuntu/
  2. See the blank space after post title.

Actual result:

Showing blank space.

Expected result:

It should either display the banner or block, instead showing huge white space beyond the original banner size.

Reproduces how often:

Easily reproduced all the time.

Brave version (brave://version info)

Brave | 0.60.4 Chromium: 72.0.3626.17 (Official Build) dev(64-bit)
Revision | 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
(Also tried on Brave Beta and Release channels and the result is same)

Reproducible on current release:

Yes.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? - YES.
  • Is the issue reproducible on the latest version of Chrome? - NO.
@srirambv
Copy link
Contributor

Could you try changing the location of the banner image and check if it works? The path might be getting filtered out by the adblock regex string.

@srirambv srirambv modified the milestone: 1.x Backlog Dec 27, 2018
@srirambv srirambv added the needs-more-info The report requires more detail before we can decide what to do with this issue. label Dec 27, 2018
@avndp
Copy link
Author

avndp commented Dec 27, 2018

Could you try changing the location of the banner image and check if it works? The path might be getting filtered out by the adblock regex string.

Tried it already in footer & sidebar and nothing worked.

@srirambv
Copy link
Contributor

Tried it already in footer & sidebar and nothing worked.

Not the location of the banner on the page but the path in which you have the banner image uploaded and may be rename the file in the current upload path itself.

@avndp
Copy link
Author

avndp commented Dec 28, 2018

Tried it already in footer & sidebar and nothing worked.

Not the location of the banner on the page but the path in which you have the banner image uploaded and may be rename the file in the current upload path itself.

When removed 728x90 from the image file name, it's working fine. Also understood that it is one form of detection (file name) for Brave for blocking ads. Would be great if Brave does not block ads that links to brave itself, may be I'm wrong too.

Thanks for the help @srirambv

@srirambv srirambv removed the needs-more-info The report requires more detail before we can decide what to do with this issue. label Dec 29, 2018
@srirambv srirambv added this to the Dupe / Invalid / Not actionable milestone Dec 29, 2018
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants