Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Wallet) Add support for Solana NFT in NFT detail screen #27803

Closed
simoarpe opened this issue Jan 13, 2023 · 2 comments · Fixed by brave/brave-core#16747
Closed

(Wallet) Add support for Solana NFT in NFT detail screen #27803

simoarpe opened this issue Jan 13, 2023 · 2 comments · Fixed by brave/brave-core#16747

Comments

@simoarpe
Copy link

Implement support for Solana NFT in NFT detail screen showing image (if supported), and description (if present).

Note: getSolTokenMetadata() is used to fetch Solana NFT metadata. (Sol NFT = token.isNft && !token.isErc721)

Solana NFT Json Example

{
   "attributes":[
      {
         "trait_type":"Background",
         "value":"Sky"
      },
      {
         "trait_type":"Skin",
         "value":"the usual"
      },
      {
         "trait_type":"Clothing",
         "value":"313 hoodie"
      },
      {
         "trait_type":"Mouth",
         "value":"313 mask"
      },
      {
         "trait_type":"Eye",
         "value":"Disco shades"
      },
      {
         "trait_type":"Headgear",
         "value":"313 hoodie"
      }
   ],
   "collection":{
      "family":"Cets on Creck",
      "name":"Cets on Creck"
   },
   "description":"",
   "edition":9,
   "external_url":"",
   "image":"https://arweave.net/t3Kq_BeIQevIp2FXygJGP8UUjdlStu5ltBt4eZblc-g?ext=png",
   "name":"Cet #10",
   "properties":{
      "category":"image",
      "creators":[
         {
            "address":"9Da5CoqR8H4YGWEYK6jtcTU69rr6XEkffadN8UFjJkeA",
            "share":30
         },
         {
            "address":"73sKMbDcc8Tze8h8wRKu22jS93NUvq6CwbDfwJPoNAX4",
            "share":20
         },
         {
            "address":"HMWMLwEcnQBR57yhsyyAhfavzac8vZbx1m4EPtYEdKkM",
            "share":30
         },
         {
            "address":"4qcJowy8guEuJ1RJx9XDxyneP3H12XTT19nZ7YaVjaFr",
            "share":20
         }
      ],
      "files":[
         {
            "type":"image/png",
            "uri":"9.png"
         }
      ]
   },
   "seller_fee_basis_points":888,
   "symbol":"CoC"
}

Solana NFT example link: https://opensea.io/assets/solana/C2b9dQ68jFRTX1xuMedq6FfKCjTWvdWnu8DPQC1zbmZq

@kjozwiak
Copy link
Member

kjozwiak commented Feb 1, 2023

The above requires 1.48.153 or higher for 1.48.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2023

Verification passed on the following devices running 1.48.155

  • Verified steps from brave/brave-core#16747
  • Verified able to view NFT details screen for Solana NFT
  • Verified able to view image in details screen
  • Verified NFT details screen shows description, blockchain, token standard and mint address details
  • Verified clicking on the Mint address loads the blockchain explorer and loads the NFT details
  • Verified Mint address is truncated in the middle and shows the first four letters and last four letter
  • Verified Token standard shows as SPL
  • Encountered #28301
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
27803-ARM.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants