Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions.brave.com #28

Closed
3 of 10 tasks
bbondy opened this issue Dec 5, 2017 · 5 comments
Closed
3 of 10 tasks

extensions.brave.com #28

bbondy opened this issue Dec 5, 2017 · 5 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/extensions priority/P4 Planned work. We expect to get to it "soon".

Comments

@bbondy
Copy link
Member

bbondy commented Dec 5, 2017

We would like to have a page showcasing extensions which are installable in the Brave browser. Users could visit this page, find extensions they're interested in, and then install them

Milestones

  • Stand up a REST API around the store functionality. Used to fetch extension details
  • Create the minimum HTML/JavaScript needed for a client page to call the REST API and show the results (even just if in a div)
  • Get the client page using React (including Brave UI)
  • Update client page with JavaScript needed to install an extension (one of the extensions being listed)
  • If extensions are already installed, show a difference in the UI ("already installed")
  • Have a details page available for each extension. This would route to a different URL like /store/extension-id-here. We'd want to be storing enough information to make this useful (ex: instead of just extension id, name, version- we should pull more fields)
  • Componentize the UI code using React - use Brave UI where possible
  • Create unit tests for the REST API
  • Integrate a linter (ex: standard) with the project
  • Setup a git pre-push hook to ensure lint/tests pass before a push is done

Taking this to the next level

There are a few things we could do to make this experience better which are definitely related, but should be captured in different issues.

  • Updating extensions (perhaps by calling the REST API?)
  • Adding new extensions get added to the store
  • Vetting extensions for quality (ex: not malware, not making risky calls)
  • Management interface for extensions (for our use- ex: used to approve/reject extensions)
@bbondy bbondy added this to the Milestone 3: To be able to market and release 1.0 milestone Dec 5, 2017
cezaraugusto pushed a commit that referenced this issue May 15, 2018
scripts to build linux installer packages
@bbondy bbondy changed the title Make extension installation UI extensions.brave.com Jun 4, 2018
@bbondy bbondy added this to Ailin Liao in 0.55.x - Release Jun 6, 2018
@bsclifton
Copy link
Member

cc: @sidstamm

@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.0 Aug 16, 2018
@bbondy
Copy link
Member Author

bbondy commented Aug 16, 2018

Moved this from 0.55.x to 1.0 milestone
cc @davidtemkin @rebron

@bbondy bbondy moved this from Ailin Liao to Matt bacchi in 0.55.x - Release Sep 6, 2018
@bbondy bbondy moved this from Matt bacchi to Pete Miller in 0.55.x - Release Sep 6, 2018
@bbondy bbondy moved this from Pete Miller to Anthony Tseng in 0.55.x - Release Sep 6, 2018
@bbondy bbondy moved this from Anthony Tseng to Emerick Rogul in 0.55.x - Release Sep 6, 2018
@bbondy bbondy moved this from Emerick Rogul to Anthony Tseng in 0.55.x - Release Sep 6, 2018
@bbondy bbondy moved this from Anthony Tseng to Brian Clifton in 0.55.x - Release Sep 6, 2018
@bbondy bbondy removed this from Brian Clifton in 0.55.x - Release Sep 9, 2018
@bbondy bbondy modified the milestones: 1.0 (0.56.x), 1.x Backlog Sep 29, 2018
@rebron
Copy link
Collaborator

rebron commented Oct 4, 2018

cc @mrzealot

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Oct 5, 2018
@rebron rebron self-assigned this Oct 5, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@ilyaigpetrov
Copy link

I think extensions.brave.com risks to get censored in some countries because of some extensions published like Dissenter. Could you, please, consider making extensions installable and updatable via IPFS? E.g. from http://localhost:8080/ipns/extensions.brave.com. Let me know if I should create a separate issue for this feature request.

@bsclifton bsclifton added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Sep 14, 2020
@bsclifton
Copy link
Member

bsclifton commented Sep 14, 2020

Closing as stale. I know we'd like to do this - and we had created https://github.com/brave-experiments/brave-extension-store but never finished unfortunately.

If we'd like to tackle this in the future, I think we can create a spec and then either un-archive brave-extension-store or create a new repo/page.

Also - see security concern raised here #637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/extensions priority/P4 Planned work. We expect to get to it "soon".
Projects
None yet
Development

No branches or pull requests

6 participants