Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messaging on NTP SI in unconnected or grandfather unverified state #28016

Closed
btlechowski opened this issue Jan 24, 2023 · 4 comments · Fixed by brave/brave-core#16860
Closed

Comments

@btlechowski
Copy link

In unconnected and grandfather unverified states we show message that user is paid for viewing ads.

Steps to Reproduce

  1. Clean profile
  2. Enable rewards and ads
  3. Open NTP till NTP SI is shown

Actual result:

Message states that user is earning tokens when viewing the NTP SI
Note: Learn More opens https://brave.com/brave-rewards/

image
image

Expected result:

We should urge user to connect to the custodian

Similar to state when user has not enabled rewards:
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.48.132 Chromium: 109.0.5414.87 (Official Build) beta (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Linux

cc @tmancey @Miyayes @LaurenWags

@Miyayes
Copy link
Collaborator

Miyayes commented Jan 25, 2023

Will remove this blue tooltip.

@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 25, 2023
@Miyayes
Copy link
Collaborator

Miyayes commented Jan 25, 2023

Uplift to 1.48.x.

@kjozwiak
Copy link
Member

The above requires 1.48.147 or higher for 1.48.x verification 👍

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 31, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Jan 31, 2023

Verified with

Brave | 1.48.149 Chromium: 109.0.5414.119 (Official Build) beta (x86_64)
-- | --
Revision | 772095164c7d5d4e73160f858efed3b5e87eca83-refs/branch-heads/5414@{#1458}
OS | macOS Version 12.6.3 (Build 21G419)

Verified the test plan from brave/brave-core#16860 (comment).

  1. On a new profile, confirmed that the first time the NTP SI is shown (when you have not joined Brave Rewards), there is no tooltip displayed.
  2. On a new profile, confirmed that after joining Brave Rewards (no custodian connected), the first time the NTP SI is shown there is no tooltip displayed.
1 2
1 2

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Brave Rewards
  
Done
Ads
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants