Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Update "Verified creator" blue checkmark icon #28209

Closed
Miyayes opened this issue Feb 1, 2023 · 2 comments · Fixed by brave/brave-core#18878
Closed

[Android] Update "Verified creator" blue checkmark icon #28209

Miyayes opened this issue Feb 1, 2023 · 2 comments · Fixed by brave/brave-core#18878
Assignees
@sujitacharya2005
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/P2P-Send feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Brave Rewards
Milestone
1.56.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 1, 2023 •
edited by kjozwiak
Loading

Android version of #28208.

Test Plan

@brave/qa-team can find some STR/Cases via brave/brave-core#18878 (comment) & brave/brave-core#18878 (comment).
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality labels Feb 1, 2023
@Miyayes Miyayes added this to New Issues in Brave Rewards via automation Feb 1, 2023
@Miyayes Miyayes moved this from New Issues to Backlog in Brave Rewards Feb 22, 2023
@Miyayes Miyayes moved this from Backlog to On deck in Brave Rewards Feb 22, 2023
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 11, 2023
@sujitacharya2005 sujitacharya2005 mentioned this issue Jun 13, 2023
Merged
25 tasks
Brave Rewards automation moved this from On deck to Done Jun 15, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 15, 2023
@brave-builds brave-builds mentioned this issue Jun 17, 2023
Merged
7 tasks
@kjozwiak kjozwiak added QA/Test-All-Platforms Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected labels Jun 21, 2023
@kjozwiak
Copy link
Member

The above requires 1.53.102 or higher for 1.53.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 22, 2023
@hffvld
Copy link
Contributor

hffvld commented Jun 23, 2023 •
edited
Loading

Verified on Pixel 2 XL, Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Pixel 2 XL [taimen-user  8.1.0 OPM2.171026.006.H1 release-keys]
- Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
- Pixel 7 [panther_beta-user 14 UPB3.230519.008 release-keys]
Brave build: 1.53.102
Chromium: 114.0.5735.133 (Official Build) (64-bit)
Revision: fbfa2ce68d01b2201d8c667c2e73f648a61c4f4a-refs/branch-heads/5735@{#1270}

Filed follow-up issue #31246

STEPS:

  1. Launch Brave
  2. Eanble Rewards Staging environment > Enable Rewards > Connect custodian
  3. Open verified creator websites > Verify the following

ACTUAL RESULTS:

Pixel 2 XL [Android 8] (Phone)
1 2 3 4
1 2 3 4
5 6
1 2

Screen_21-03-13

Galaxy Tab S8 [Android 13] (Tablet)
1 2 3 4
1 2 3 4
5 6 7 8
1 2 3 4
9 10 11 12
1 2 3 4

Screen_20-43-17

Pixel 7 [Android 14] (Phone)
1 2 3 4
1 2 3 4
5 6 7 8
1 2 3 4
9 10 11 12
1 2 3 4

Screen_20-54-41

@hffvld hffvld mentioned this issue Jun 23, 2023
Closed
@hffvld hffvld added QA Pass - Android Tab QA Pass - Android 8+ and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 23, 2023
@kjozwiak kjozwiak mentioned this issue Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sujitacharya2005 sujitacharya2005

Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/P2P-Send feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Brave Rewards
  
Done
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Update rewards verified icon brave/brave-core
6 participants
@kjozwiak @deeppandya @Miyayes @sujitacharya2005 @brave-builds @hffvld