Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earn Tokens & Give Back misaligned via rewards panel #28278

Closed
kjozwiak opened this issue Feb 3, 2023 · 2 comments · Fixed by brave/brave-core#17331
Closed

Earn Tokens & Give Back misaligned via rewards panel #28278

kjozwiak opened this issue Feb 3, 2023 · 2 comments · Fixed by brave/brave-core#17331
Assignees
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Feb 3, 2023

Description

Looks like the Earn Tokens & Give Back text within the rewards panel is misaligned when first tapping on the BAT icon and starting the onboarding process. Definitely related to the new rewards refactor via 1.48.x as this isn't happening within 1.47.x.

Steps to reproduce

  1. install 1.48.154 Chromium: 110.0.5481.52 and run through onboarding (can skip everything)
  2. tap on the rewards panel and you'll see the misaligned text/strings within the panel

Actual result

panelRewards

Expected result

image

Issue reproduces how often

100% reproducible using the SRT/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6 (Phone)
  • Android version: Android 13

Brave version

Brave | 1.48.154 Chromium: 110.0.5481.52 (Official Build) (32-bit)
--- | ---
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Android 13; Build/TQ1A.230105.002

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @Miyayes @LaurenWags @deeppandya

@kjozwiak kjozwiak added bug feature/rewards QA/Yes OS/Android Fixes related to Android browser functionality labels Feb 3, 2023
@kjozwiak kjozwiak added this to New Issues in Brave Rewards via automation Feb 3, 2023
@Miyayes
Copy link
Collaborator

Miyayes commented Feb 8, 2023

@deeppandya Remove BAT icon in the Android case.

@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 8, 2023
@Miyayes Miyayes moved this from New Issues to In progress in Brave Rewards Feb 8, 2023
Brave Rewards automation moved this from In progress to Done Feb 27, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 27, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 14, 2023

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.50.90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants