Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up issue to #26378 - Default browser should be selected in Import Settings screen during onboarding process #28573

Closed
MadhaviSeelam opened this issue Feb 17, 2023 · 1 comment · Fixed by brave/brave-core#17270
Assignees
Labels
bug feature/importer onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop QA Pass-Win64 QA/Yes release-notes/include

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 17, 2023

Description

#26378 description mentioned that The default browser will be selected. However, I've noticed during testing of #27641. that none of non Brave browsers, i.e Edge for my testing, selected. (I've confirmed Edge is default (Settings >> Apps >>Default apps>>Reset all default Apps >> Reset and clicked a link Slack and it opened in the Edge browser)

Steps to Reproduce

  1. Install 1.49.100
  2. launch Brave
  3. click Skip

Actual result:

Microsoft Edge wasn't selected
image

Expected result:

Microsoft Edge should be selected

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.49.100 Chromium: 110.0.5481.100 (Official Build) beta (64-bit)
-- | --
Revision | 4be7a36f7cb943af6118e449bbab494b43dcaddd-refs/branch-heads/5481_77@{#14}
OS | Windows 11 Version 21H2 (Build 22000.1574)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @spylogsster

cc: @stephendonner

@MadhaviSeelam MadhaviSeelam added bug feature/importer QA/Yes onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop labels Feb 17, 2023
@spylogsster spylogsster self-assigned this Feb 17, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 24, 2023
@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 14, 2023
@MadhaviSeelam
Copy link
Author

MadhaviSeelam commented Mar 14, 2023

Verification PASSED using

Brave | 1.50.91 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | Windows 11 Version 22H2 (Build 22621.1265)

Pre-requisites: Selected Microsoft Edge as Default browser in Windows settings (Settings >> Apps >>Default apps>>Microsoft Edge>>Set default)

  1. Install 1.50.91
  2. launch Brave
  3. click Skip

Confirmed Microsoft Edge is selected as default browser

image

Additionally same issue is tested with Chrome Beta and Chrome Dev browsers for non-English locales via

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/importer onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants