Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC721 NFTs with same token identifiers may show incorrect balance #28627

Closed
Pavneet-Sing opened this issue Feb 21, 2023 · 1 comment · Fixed by brave/brave-core#17654
Closed

ERC721 NFTs with same token identifiers may show incorrect balance #28627

Pavneet-Sing opened this issue Feb 21, 2023 · 1 comment · Fixed by brave/brave-core#17654
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Milestone
1.51.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Feb 21, 2023 •
edited
Loading

Description

Balance are computed based on symbol and tokenId that can cause issues while computing balance of NFTs having same tokenIds on ETH.

Steps to reproduce

Note: Haven't tested but logically the issue should be reproducible with:

  1. Buy NFTs with same IDs NFT1 and NFT2
  2. The balance will be inaccurate

or can use brave/brave-ios#6954 (comment)

  1. Buy two NFTs with same contract addressed and symbol. e.g. NFT1 and NFT2
  2. Make sure the balance is accurate on Portfolio screen

Actual result

Incorrect balance

Expected result

Correct balance of NFTs with same tokenIds

Additional information

https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1676555545832879
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Feb 21, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Mar 15, 2023
Closed
25 tasks
@Pavneet-Sing Pavneet-Sing self-assigned this Mar 16, 2023
@Pavneet-Sing Pavneet-Sing changed the title ERC721 NFTs with different token identifiers may show incorrect balance ERC721 NFTs with same token identifiers may show incorrect balance Mar 17, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Mar 17, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 20, 2023
@srirambv
Copy link
Contributor

Marking as QA/No as there is no way to check this one with the new NFT tab. More info here

@srirambv srirambv added QA/No and removed QA/Yes labels Apr 26, 2023
@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release
4 participants
@Pavneet-Sing @srirambv @brave-builds @muliswilliam