Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only load http/https URLs when scanning a QR code from the URL bar #28703

Closed
SergeyZhukovsky opened this issue Feb 23, 2023 · 4 comments · Fixed by brave/brave-core#17344
Closed

Only load http/https URLs when scanning a QR code from the URL bar #28703

SergeyZhukovsky opened this issue Feb 23, 2023 · 4 comments · Fixed by brave/brave-core#17344
Assignees
@tapanmodh
Labels
enhancement OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include security
Milestone
1.49.x - Release

Comments

@SergeyZhukovsky
Copy link
Member

We need to do the same as described in iOS issue on Android for QR code reader brave/brave-ios#6997
@SergeyZhukovsky SergeyZhukovsky added enhancement security priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Feb 23, 2023
@tapanmodh tapanmodh mentioned this issue Feb 23, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 23, 2023
@brave-builds brave-builds mentioned this issue Feb 23, 2023
Merged
7 tasks
@tapanmodh tapanmodh mentioned this issue Feb 24, 2023
Merged
7 tasks
@brave-builds brave-builds modified the milestones: 1.50.x - Nightly, 1.49.x - Beta, 1.48.x - Release #6 Feb 28, 2023
@kjozwiak
Copy link
Member

The above requires 1.48.173 or higher for 1.48.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Mar 8, 2023 •
edited
Loading

Even though the above was merged into the 1.48.x branch, moving this issue into the 1.49.x milestone as we didn't have another 1.48.x release. It was uplifted into 1.49.x & 1.48.x via brave/brave-core#17350 & brave/brave-core#17363. We'll be closing/removing the 1.49.x - Release #6 milestone.

@kjozwiak kjozwiak modified the milestones: 1.48.x - Release #6, 1.49.x - Release Mar 8, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Mar 8, 2023

The above can be verified with 1.49.120 as this landed a while ago via 1.49.x but was waiting for a potential 1.48.x release as mentioned above.

@Uni-verse
Copy link
Contributor

Uni-verse commented Mar 9, 2023 •
edited
Loading

Verified on Samsung GS 21 5G using version(s):

Brave	1.49.120 Chromium: 111.0.5563.64 (Official Build) (64-bit) 
Revision	c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS	Android 13;

Test Plan: brave/brave-ios#6997 (comment)

  • Ensured that any non-http/https URL should be submitted as a search query to the users default search engine

screenshot-1678402025767

This was referenced Mar 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tapanmodh tapanmodh

Labels
enhancement OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include security
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Only load http/https URLs when scanning a QR code from the URL bar brave/brave-core
5 participants
@kjozwiak @tapanmodh @SergeyZhukovsky @Uni-verse @brave-builds