Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not open brave://welcome in incognito #28704

Closed
spylogsster opened this issue Feb 23, 2023 · 4 comments · Fixed by brave/brave-core#17382
Closed

Do not open brave://welcome in incognito #28704

spylogsster opened this issue Feb 23, 2023 · 4 comments · Fixed by brave/brave-core#17382
Assignees
@spylogsster
Labels
feature/importer onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.50.x - Release

Comments

@spylogsster
Copy link

same as brave://settings/importData
@spylogsster spylogsster self-assigned this Feb 23, 2023
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". onboarding Front-end related to helping a new user learn about features within the browser. labels Feb 24, 2023
@spylogsster spylogsster mentioned this issue Feb 27, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 27, 2023
@rebron rebron added this to Completed in Front End Feb 28, 2023
@stephendonner
Copy link

stephendonner commented Mar 13, 2023 •
edited

@spylogsster how about in Guest window? Currently, that works, in

Brave 1.50.86 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 11.7.4 (Build 20G1120)

Screen Shot 2023-03-12 at 5 41 49 PM

@spylogsster spylogsster mentioned this issue Mar 13, 2023
Closed
@spylogsster
Copy link
Author

@spylogsster how about in Guest window? Currently, that works, in

Brave 1.50.86 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 11.7.4 (Build 20G1120)
Screen Shot 2023-03-12 at 5 41 49 PM

thanks for checking, created #29012

@stephendonner
Copy link

Verified PASSED using

Brave 1.50.90 Chromium: 111.0.5563.64 (Official Build) beta (x86_64)
Revision c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS macOS Version 11.7.4 (Build 20G1120)

Steps:

  1. installed 1.50.90
  2. launched Brave
  3. clicked on New Private Window
  4. tried to load brave://welcome
  5. confirmed it focused the already-open brave://welcome tab
  6. clicked on New Private Window with Tor
  7. tried to load brave://welcome
  8. confirmed it focused the already-open brave://welcome tab

28704

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 14, 2023
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.50.91 Chromium: 111.0.5563.64 (Official Build) beta (64-bit)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | Windows 11 Version 22H2 (Build 22621.1265)

Steps:

  1. installed 1.50.91
  2. launched Brave
  3. clicked on New Private Window
  4. tried to load brave://welcome
  5. confirmed it focused the already-open brave://welcome tab
  6. clicked on New Private Window with Tor
  7. tried to load brave://welcome
  8. confirmed it focused the already-open brave://welcome tab
2023-03-14_13h41_02.mp4

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 14, 2023
@LaurenWags LaurenWags mentioned this issue Apr 4, 2023
Closed
@rebron rebron removed this from Completed in Front End Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/importer onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging a pull request may close this issue.

Do not open brave://welcome in incognito brave/brave-core
5 participants
@stephendonner @spylogsster @rebron @brave-builds @MadhaviSeelam