Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethereum and Location content settings are missing in a site content settings #28773

Closed
GeetaSarvadnya opened this issue Feb 27, 2023 · 3 comments · Fixed by brave/brave-core#17390
Assignees
Labels
bug OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes regression release-notes/exclude

Comments

@GeetaSarvadnya
Copy link

Description

Ethreum and Location content settings are missing in a site content settings in CR 110 and CR 111 works fine in CR 109

Steps to Reproduce

  1. 1.48.x (CR 110) or 1.50.62 (CR 111)
  2. Open a site
  3. Go into Site settings
  4. Ethreum and Location content settings are missing in a site content settings

Actual result:

CR 111
image

CR 110
image (8)

Expected result:

CR 109
image (7)

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.50.62 Chromium: 111.0.5563.33 (Official Build) nightly (64-bit)
Revision 19bd6d0186b7912604e18191826dab9d1df00e2e-refs/branch-heads/5563@{#557}
OS Windows 10 Version 21H2 (Build 19044.2604)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes in 1.48.x (cr 110) not in 1.47.x (cr 109)
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @rebron @mkarolin @emerick

@emerick emerick changed the title Ethreum and Location content settings are missing in a site content settings Ethereum and Location content settings are missing in a site content settings Feb 27, 2023
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. release-notes/exclude labels Feb 27, 2023
@emerick emerick added this to the 1.50.x - Nightly milestone Feb 27, 2023
@rebron rebron added this to Completed in General Feb 27, 2023
@rebron rebron added this to Completed in Settings Feb 27, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2023

The above requires 1.49.116 or higher for 1.49.x verification 👍

@LaurenWags
Copy link
Member

Labelled as QA/Blocked since this issue cannot be tested until #28861 is resolved.

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue and removed QA/Blocked labels Mar 3, 2023
@LaurenWags
Copy link
Member

Verified with

Brave | 1.49.118 Chromium: 111.0.5563.50 (Official Build) (x86_64)
-- | --
Revision | 39f3dfc5023fe60997adc4f6cf5439cfa3e6968a-refs/branch-heads/5563@{#903}
OS | macOS Version 12.6.3 (Build 21G419)

Verified STR from description.
Confirmed labels are displayed as expected.

Screen Shot 2023-03-03 at 9 05 12 AM

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 3, 2023
@rebron rebron removed this from Completed in Settings Mar 6, 2023
@rebron rebron removed this from Completed in General Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-macOS QA/Yes regression release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants