Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Crash on rewards tipping #29041

Closed
SergeyZhukovsky opened this issue Mar 13, 2023 · 2 comments · Fixed by brave/brave-core#17854
Closed

[Android] Crash on rewards tipping #29041

SergeyZhukovsky opened this issue Mar 13, 2023 · 2 comments · Fixed by brave/brave-core#17854
Assignees
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

I found that crash in backtrace on a stable 1.49.122 version. It's unknown why that could happen. Most likely Activity was on a state to be destroyed or was destroying. We would better catch NullPointerException and ignore it.
For verifying just make sure that tips go through.

java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setAlpha(float)' on a null object reference
        at org.chromium.chrome.browser.rewards.BraveRewardsTipConfirmationListener.V2(BraveRewardsTipConfirmationListener.java:5)
        at org.chromium.chrome.browser.BraveRewardsNativeWorker.onBalance(BraveRewardsNativeWorker.java:571)
        at android.os.MessageQueue.nativePollOnce(Native Method)
        at android.os.MessageQueue.next(MessageQueue.java:335)
        at android.os.Looper.loopOnce(Looper.java:186)
        at android.os.Looper.loop(Looper.java:313)
        at android.app.ActivityThread.main(ActivityThread.java:8669)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)
@SergeyZhukovsky SergeyZhukovsky added crash priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Mar 13, 2023
@Miyayes Miyayes added this to New Issues in Brave Rewards via automation Mar 14, 2023
@Miyayes Miyayes moved this from New Issues to In progress in Brave Rewards Mar 15, 2023
@Miyayes Miyayes changed the title Crash on rewards tipping [Android] Crash on rewards tipping Mar 15, 2023
@deeppandya deeppandya removed their assignment Mar 26, 2023
Brave Rewards automation moved this from In progress to Done Apr 14, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 14, 2023
@kjozwiak
Copy link
Member

The above requires 1.50.121 or higher for 1.50.x verification 👍

@GeetaSarvadnya
Copy link

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.50.121

Ensured that one-time/monthly tipping worked without any crashes/obvious issues as per the following:

Example Example Example Example Example
Screenshot_20230419_181716 Screenshot_20230419_181733 Screenshot_20230419_181753 Screenshot_20230419_181848 Screenshot_20230519_182115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants