Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Loading... spinner animation is NOT shown in the BR panel when rewards custodian is failed to fetch the balance #29054

Closed
GeetaSarvadnya opened this issue Mar 14, 2023 · 3 comments · Fixed by brave/brave-core#18012
Assignees
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #28549 (comment)

[Android] Loading... spinner animation is NOT shown in the BR panel when rewards custodian is failed to fetch the balance

Steps to reproduce

pre-req: have Charles Proxy set up to return 500 error for https://api.sandbox.gemini.com/v1/balances)

  1. Clean profile 1.50.90
  2. Enable staging rewards flags via QA preferences
  3. Enable rewards
  4. Connect Gemini wallet
  5. Open brave://rewrads settings and brave://rewards-internals pages, ensured that the Loading... spinner animation is shown
  6. Open BR panel, Loading... spinner animation is NOT shown

Actual result

Loading... spinner animation is NOT shown in the BR panel when rewards custodian is failed to fetch the balance

Screenshot_20230314-163321_Brave - Beta

Expected result

Loading... spinner animation should be shown in the BR panel when rewards custodian is failed to fetch the balance

should be same as Desktop
image

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy
  • Android version: 12

Brave version

1.50.90

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

CC: @Miyayes @brave/qa-team @deeppandya

@GeetaSarvadnya GeetaSarvadnya added this to New Issues in Brave Rewards via automation Mar 14, 2023
@Miyayes Miyayes added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 15, 2023
@Miyayes Miyayes moved this from New Issues to Backlog in Brave Rewards Mar 15, 2023
@Miyayes Miyayes added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 10, 2023
Brave Rewards automation moved this from Backlog to Done Apr 14, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 14, 2023
@Miyayes
Copy link
Contributor

Miyayes commented Apr 14, 2023

Will be orange spinner (without "Loading...") text on Android. That is acceptable for this iteration.

@kjozwiak
Copy link
Member

The above requires 1.50.120 or higher for 1.50.x verification 👍

@GeetaSarvadnya
Copy link
Author

Verification PASSED on Samsung Galaxy version 12 running Bravemonoarm64.apk_1.50.120

  • Verified the STR from the description and ensured that the spinner animation is shown in the BR panel
BR panel brave://rewards brave://rewards-internals
Screenshot_20230418-205523_Brave Screenshot_20230418-205614_Brave Screenshot_20230418-205627_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

6 participants