Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Wallet) Refactor visible asset list #29412

Closed
simoarpe opened this issue Mar 30, 2023 · 1 comment · Fixed by brave/brave-core#17840
Closed

(Wallet) Refactor visible asset list #29412

simoarpe opened this issue Mar 30, 2023 · 1 comment · Fixed by brave/brave-core#17840
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.52.x - Release

Comments

@simoarpe
Copy link

simoarpe commented Mar 30, 2023 •
edited
Loading

Description

Performs refactoring to improve visible asset list of EditVisibleAssetsBottomSheetDialogFragment.
The fragment EditVisibleAssetsBottomSheetDialogFragment has different entry points and shows a list containing coins and NFTs.

When EditVisibleAssetsBottomSheetDialogFragment is shown from PortfolioFragment it should display all non-NFT tokens (including native assets).

When EditVisibleAssetsBottomSheetDialogFragment is shown from NftFragment it should display only NFT tokens (excluding native assets).

Screenshot_1680182030
@simoarpe simoarpe added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Mar 30, 2023
@simoarpe simoarpe self-assigned this Mar 30, 2023
This was referenced Mar 30, 2023
Closed
Merged
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Mar 31, 2023
@srirambv
Copy link
Contributor

Verification passed the following devices running 1.52.92 x64 build

  • Verified steps from brave/brave-core#17840
  • Verified NFT's are not listed under Edit visible asset lists
  • Verified tokens are not listed under Edit visible NFTs
  • Encountered #30259
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
29412-ARM.mp4
29412-Tab.mp4

@kjozwiak kjozwiak mentioned this issue May 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release
Development

Successfully merging a pull request may close this issue.

Refactor visible asset list in EditVisibleAssetsBottomSheetDialogFragment brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds