Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when you try to tip someone #29562

Closed
SergeyZhukovsky opened this issue Apr 6, 2023 · 2 comments · Fixed by brave/brave-core#17955
Closed

Crash when you try to tip someone #29562

SergeyZhukovsky opened this issue Apr 6, 2023 · 2 comments · Fixed by brave/brave-core#17955
Assignees
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected crash feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

That is basically the same as #28088 where it wasn't fixed. It happens on stable channel as well and only on Android 8 devices.
The steps are:

  • install Brave on Android 8.
  • connect to a provider.
  • try to tip some creator by clicking Send Tip button.
tipping_crash.webm
@SergeyZhukovsky SergeyZhukovsky added crash priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels Apr 6, 2023
@SergeyZhukovsky SergeyZhukovsky self-assigned this Apr 6, 2023
@SergeyZhukovsky SergeyZhukovsky added this to New Issues in Brave Rewards via automation Apr 6, 2023
@SergeyZhukovsky SergeyZhukovsky added the Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected label Apr 6, 2023
Brave Rewards automation moved this from New Issues to Done Apr 6, 2023
@SergeyZhukovsky SergeyZhukovsky added this to the 1.52.x - Nightly milestone Apr 6, 2023
@kjozwiak
Copy link
Member

The above requires 1.50.118 or higher for 1.50.x verification 👍

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 18, 2023

Verified on Samsung GS 21 running Android 13 using the following build(s):

Brave	1.50.120 Chromium: 112.0.5615.121 (Official Build) (64-bit) 
Revision	39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS	Android 13; Build/TP1A.220624.014

Test Case:

  1. Connect rewards account to provider
  2. Send tip to creator by clicking Send Tip and confirm its displayed in the tips
  3. Send custom tip to creator by setting a custom amount
  4. Set monthly tip for a creator and confirm it shows in the monthly tips list.
  • Confirmed sending tip using Send Tip is successful and shows up pending contributions.
  • Confirmed crash does not occur when tipping creators.
  • Confirmed monthly tips is working.
  • Confirmed sending tip with a custom tip amount works
Send Tip (Default) Custom Tip (0.25) Monthly Tip Pending contributions Monthly Tips
screenshot-1681850061819 screenshot-1681850039734 screenshot-1681850176135 screenshot-1681850199234 screenshot-1681850206108

Verification passed on Huawei P20 with Android 8.1.0 running 1.50.120 x64 build

  • Verified no crash when sending a one time tip or setting up a monthly tip
29562.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected crash feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants