Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-customized default search engine should be Naver, not Google, on upgrade #29569

Open
stephendonner opened this issue Apr 7, 2023 · 0 comments
Labels
feature/search needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop QA/Yes

Comments

@stephendonner
Copy link

Description

Un-customized default search engine should be Naver, not Google, on upgrade

Found while testing #18855

Steps to Reproduce

  1. set OS region to South Korea
  2. install 1.50.114
  3. launch Brave
  4. open brave://settings/search
  5. confirm and leave search-engine defaults of Google and Brave for Normal window and Private window, respectively
  6. installed 1.51.79 atop
  7. launched Brave
  8. opened brave://settings/search

Actual result:

Google remains the default for Normal window, and Brave is (correctly) default for Private window

1.50.114 1.51.79
스크린샷 2023-04-06 오후 6 25 10 스크린샷 2023-04-06 오후 6 46 48

Expected result:

Naver (in Unicode) should be default for Normal window, if the user hasn't customized their default from 1.50.114

스크린샷 2023-04-06 오후 6 42 46

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.51.78 Chromium: 112.0.5615.49 (공식 빌드) beta (x86_64)
개정 bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS macOS 버전 11.7.5(빌드 20G1225)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

/cc @simonhong @rebron @brave/qa-team

@rebron rebron added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/search needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop QA/Yes
Projects
None yet
Development

No branches or pull requests

2 participants