Add Naver and Daum to the default search provider list for South Korea

[simonhong]

It should have Naver and Daum search provider as a default.

[simonhong]

@rebron For android, we need image resources(and labels) for these new search providers for onboarding screen.

[jenn-rhim]

Naver and Daum logos

[jenn-rhim]

i'm checking to see why the colors of the Daum logo come out all off. please hold...

[jenn-rhim]

it should look like this

[jenn-rhim]

ok. found the issue and am posting the adjusted .svg that we should use:
cc @rebron

[simonhong]

@rebron We also want to change default provider as Naver or Daum at SK?
We set google as a default now.

[anthonypkeane]

@simonhong did you get the one line sentence for this search engine on Android?

Also, @deeppandya just making sure you know about this so the change doesn't conflict with any other logic. (cc @timchilds )

[simonhong]

@simonhong did you get the one line sentence for this search engine on Android?

@anthonypkeane Yes, I got - brave/brave-core#10590 (comment)

Also, @deeppandya just making sure you know about this so the change doesn't conflict with any other logic. (cc @timchilds )

@deeppandya also reviewed this change but reverted as we found some bug when default provider is updated.
Desktop fix is merged and Android fix is in reviewing. When it's finished, I'll reland PR for this again.

[stephendonner]

Verification PASSED using

Brave	1.51.79 Chromium: 112.0.5615.49 (Official Build) beta (x86_64)
Revision	bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS	macOS Version 11.7.5 (Build 20G1225)

Shared Steps:

1. set my macOS region to South Korea
2. installed 1.51.79
3. launched Brave
4. opened brave://settings/search

region	brave://settings/search

Defaults - PASSED

(continued from Shared Steps)

• confirmed Naver is default for Normal window
• confirmed Brave is default for Private window

Normal window:

• confirmed Naver favicon/search-engine icon in a new-tab window
• confirmed searches from the URL bar went to https://search.naver.com/search.naver?ie=UTF-8&query=speedtest&sm=chr_hty

Private window:

• confirmed Brave Search is shown (without icon) in the URL bar of the new-tab window
• confirmed searches from the URL bar went to https://search.brave.com/search?q=speedtest&source=desktop

example	example	example	example	example

Custom search-engine choice - PASSED

(continued from Shared Steps)

Normal window:

• confirmed I could set another search engine (Brave) as default for Normal window searches
• confirmed after doing so, searches went to https://search.brave.com/search?q=speedtest&source=desktop

Private window:

• confirmed I could set another search engine (Naver) as default for Private window searches
• confirmed after doing so, searches went to https://search.naver.com/search.naver?ie=UTF-8&query=speedtest&sm=chr_hty

example	example	example

brave://settings/searchEngines - PASSED

(continued from Shared Steps)

• confirmed that both Naver and Daum are listed along with the other search engines
• confirmed Naver is listed with (default) after its name
• confirmed I could reassign the default for Normal window to Brave
• confirmed after doing so, searches from the URL bar went to https://search.brave.com/search?q=speedtest&source=desktop

example	example	example

---

Upgrades:

Defaults - PASSED

1. set OS region to South Korea
2. installed 1.50.114
3. launched Brave
4. opened brave://settings/search
5. confirmed and left left search-engine defaults of Google and Brave for Normal window and Private window, respectively
6. installed 1.51.79 atop
7. launched Brave
8. opened brave://settings/search

Confirmed defaults of Google and Brave for Normal window and Private window, respectively

1.50.114	1.51.79

Logged #29569

Custom search-engine choice(s) - PASSED

1. set OS region to South Korea
2. installed 1.50.114
3. launched Brave
4. opened brave://settings/search
5. search-engine defaults to DuckDuckGo and StartPage for Normal window and Private window, respectively
6. installed 1.51.79 atop
7. launched Brave
8. opened brave://settings/search

Confirmed custom search-engine choices of DuckDuckGo and StartPage for Normal window and Private window, respectively

1.50.114 defaults	1.50.114, custom	1.51.79, custom	brave://settings/searchEngines

[MadhaviSeelam]

Verification PASSED using

Brave | 1.51.84 Chromium: 112.0.5615.49 (Official Build) beta (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 11 Version 22H2 (Build 22621.1413)

Testcase 1: New profile

Case 1: Normal Window - Updated Default SE list - Naver default SE - PASSED

1. set Windows Country or region to Korea and Regional format to Korean(Korea)
2. Installed 1.51.84
3. launched Brave and skipped onboarding
4. opened brave://settings/search
5. confirmed search engine list show South Korea specific new search provider list in Normal Window
   • Brave, Naver, Daum and Google
6. confirmed Naver is selected as the default SE
7. confirmed Brave is at the top of the dropdown
8. confirmed Naver is retained after restarting the browser couple of times
9. confirmed the new default SE (Naver) is also reflected via brave://settings/searchEngines
10. confirmed Naver search-engine (without favicon) in a new-tab window
11. Naver favicon was fetched and shown when clicked on new tab
12. confirmed searches from the URL bar went to https://search.naver.com/search.naver?ie=UTF-8&query=brave&sm=chr_hty

step 1	step 5	step 6	step 7	step 9	step 10	step 11	step 12

Case 2: Private window - Updated Default SE list - Brave default SE - PASSED

1. Continue from Case 1:
   • opened brave://settings/search
2. confirmed search engine list show South Korea specific new search provider list in Private window
   • Brave, Naver, Daum and Google
3. confirmed Brave is selected as the default SE
4. confirmed Brave Search is shown (without icon) in the URL bar of the new Private window
5. confirmed searches from the URL bar went to https://search.brave.com/search?q=brave&source=desktop

step 2	step 3	step 4	step 5

Case 3: Modified SE - Daum/Naver - PASSED

1. New profile
2. launch Brave
3. click Set Brave as default Browser
4. select Naver Whale and click Import
5. click Select All and click Import profiles
6. click Finish
7. click Profile Manager/Profile list next to hamburger menu
8. select Naver Whale Person 1
9. opened brave://settings/search
10. confirmed search engine list show South Korea specific search provider list in Normal window & Private window
    • Brave, Naver, Daum and Google
11. selected Daum as the default Search engine in the dropdown list for Normal Window
12. selected Naver as the default Search engine in the dropdown list for Private Window
13. closed and relaunched Brave
14. confirmed Daum is shown as default in brave://settings/searchEngines
15. confirmed Daum is retained in the Normal window after restarting the browser
16. confirmed Naver is retained in the Private window after restarting the browser
17. opened a new tab and searched Brave in both Normal window and Private window
18. confirmed searches went to https://search.brave.com/search?q=brave&source=desktop in Normal window
19. confirmed search went to https://search.naver.com/search.naver?ie=UTF-8&query=brave&sm=chr_hty in Private window

step 4	step 5	step 7	step 10	step 11-12	step 14	step 15-16	step 18	step 19

Case 4: Additional SE testing with Guest window & Tor window - PASSED

1. New profile
2. launched Brave and skipped onboarding
3. opened brave://settings/search
4. confirmed search engine list show South Korea specific new search provider list in Normal Window
   • Brave, Naver, Daum and Google
5. confirmed Naver is selected as the default SE for Normal window
6. confirmed Brave is selected as the default SE for Private window
7. opened a guest window and confirmed Naver search engine (without favicon) in a new-tab window
8. confirmed searches from the URL bar went to https://search.naver.com/search.naver?ie=UTF-8&query=brave&sm=chr_hty
9. opened a Tor window and confirmed Brave search engine in a new-tab window
10. confirmed searches from the URL bar went to https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q=pizza

step 5-6	step 7	step 8	step 9	step 10

Testcase 2: Upgrade

Case 1: Upgrade - Default SE - Google/Brave - PASSED

1. set OS region to Korea
2. installed 1.50.114
3. launched Brave and skip onboarding
4. verified Google search shown as a default SE in a new tab URL bar
5. opened brave://settings/search
6. verified search-engine defaults of Google and Brave for Normal window and Private window, respectively
7. verified brave://settings/searchEngines page show Google as a default
8. renamed the profile Brave-Browser-Beta
9. installed 1.51.84
10. launched Brave
11. opened brave://settings/search
12. opened brave://settings/searchEngines
13. opened a new tab for Normal window
14. opened a new Private window

• Confirmed updated default search provider list Brave, Google, Naver and Daum is shown in brave://settings/searchfor bothNormal windowandPrivate window`
• Confirmed Google and Brave for Normal window and Private window, respectively listed as default SE in brave://settings/search
• Confirmed updated list Brave, Google. Naver & Daum are listed Search engines list in brave://settings/searchEngines
• Confirmed Google listed as a default SE in brave://settings/searchEngines
• Confirmed Google search in the Search bar for Normal window
• Confirmed Brave search in the Search bar for Private window

step 6	step 7	step 11(NW)	step 11(PW)	step 12	step 14	step 15

Case 2: Upgrade: Modified SE Qwant/Bing - PASSED

1. Continue from Case 1 (Testcase 2 Upgrade)
   • Default SE is Google for Normal window in brave://settings/search
   • Default SE is Brave for Private window in brave://settings/search
2. selected Qwant and Bing as search engines for Normal window and Private window respectively
3. verified Qwant is shown as a default in the Search Engine list in brave://settings/searchEngines
4. renamed the profile Brave-Browser-Beta
5. installed 1.51.84
6. launched Brave
7. opened brave://settings/search
8. opened brave://settings/searchEngines
9. opened a new tab for Normal window
10. opened a new Private window

• Confirmed Qwant and Bing selections are retained upon upgrade in brave://settings/search for Normal window and Private window respectively
• Confirmed updated list Brave, Google. Naver & Daum along with Qwant and Bing are listed Search engines list in brave://settings/searchEngines
• Confirmed Qwant is shown as default in the searchEngine list upon upgrade in brave://settings/searchEngines
• Confirmed Qwant search in the Search bar for Normal window
• Confirmed Bing in the Search bar for Private window

step 1	step 2	step 3	step 7a	step 7b	step 8	step 9	step 10

---

Verification passed on

Brave	1.51.98 Chromium: 112.0.5615.165 (Official Build) beta (64-bit)
Revision	c262f36e6b1d711ee42d4fbe1343b49960593f18-refs/branch-heads/5615@{#1297}
OS	Ubuntu 22.04 LTS

Testcase 1: New profile

Case 1: Normal Window - Updated Default SE list - Naver default SE - PASSED

1. set Windows Country or region to Korea and Regional format to Korean(Korea)
2. Installed 1.51.84
3. launched Brave and skipped onboarding
4. opened brave://settings/search
5. confirmed search engine list show South Korea specific new search provider list in Normal Window
   • Brave, Naver, Daum and Google
6. confirmed Naver is selected as the default SE
7. confirmed Brave is at the top of the dropdown
8. confirmed Naver is retained after restarting the browser couple of times
9. confirmed the new default SE (Naver) is also reflected via brave://settings/searchEngines
10. confirmed Naver search-engine (without favicon) in a new-tab window
11. Naver favicon was fetched and shown when clicked on new tab
12. confirmed searches from the URL bar went to https://search.naver.com/search.naver?ie=UTF-8&query=brave&sm=chr_hty

Case 2: Private window - Updated Default SE list - Brave default SE - PASSED

1. Continue from Case 1:
   • opened brave://settings/search
2. confirmed search engine list show South Korea specific new search provider list in Private window
   • Brave, Naver, Daum and Google
3. confirmed Brave is selected as the default SE
4. confirmed Brave Search is shown (without icon) in the URL bar of the new Private window
5. confirmed searches from the URL bar went to https://search.brave.com/search?q=brave&source=desktop

Case 3: Modified SE - Daum/Naver - PASSED

1. New profile
2. launch Brave
3. click Set Brave as default Browser
4. select Naver Whale and click Import
5. click Select All and click Import profiles
6. click Finish
7. click Profile Manager/Profile list next to hamburger menu
8. select Naver Whale Person 1
9. opened brave://settings/search
10. confirmed search engine list show South Korea specific search provider list in Normal window & Private window
    • Brave, Naver, Daum and Google
11. selected Daum as the default Search engine in the dropdown list for Normal Window
12. selected Naver as the default Search engine in the dropdown list for Private Window
13. closed and relaunched Brave
14. confirmed Daum is shown as default in brave://settings/searchEngines
15. confirmed Daum is retained in the Normal window after restarting the browser
16. confirmed Naver is retained in the Private window after restarting the browser
17. opened a new tab and searched Brave in both Normal window and Private window
18. confirmed searches went to https://search.brave.com/search?q=brave&source=desktop in Normal window
19. confirmed search went to https://search.naver.com/search.naver?ie=UTF-8&query=brave&sm=chr_hty in Private window

Case 4: Additional SE testing with Guest window & Tor window - PASSED

1. New profile
2. launched Brave and skipped onboarding
3. opened brave://settings/search
4. confirmed search engine list show South Korea specific new search provider list in Normal Window
   • Brave, Naver, Daum and Google
5. confirmed Naver is selected as the default SE for Normal window
6. confirmed Brave is selected as the default SE for Private window
7. opened a guest window and confirmed Naver search engine (without favicon) in a new-tab window
8. confirmed searches from the URL bar went to https://search.naver.com/search.naver?ie=UTF-8&query=brave&sm=chr_hty
9. opened a Tor window and confirmed Brave search engine in a new-tab window
10. confirmed searches from the URL bar went to https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q=pizza

|

--|--

Testcase 2: Upgrade

Case 1: Upgrade - Default SE - Google/Brave - PASSED

1. set OS region to Korea
2. installed 1.50.114
3. launched Brave and skip onboarding
4. verified Google search shown as a default SE in a new tab URL bar
5. opened brave://settings/search
6. verified search-engine defaults of Google and Brave for Normal window and Private window, respectively
7. verified brave://settings/searchEngines page show Google as a default
8. renamed the profile Brave-Browser-Beta
9. installed 1.51.84
10. launched Brave
11. opened brave://settings/search
12. opened brave://settings/searchEngines
13. opened a new tab for Normal window
14. opened a new Private window

• Confirmed updated default search provider list Brave, Google, Naver and Daum is shown in brave://settings/searchfor bothNormal windowandPrivate window`
• Confirmed Google and Brave for Normal window and Private window, respectively listed as default SE in brave://settings/search
• Confirmed updated list Brave, Google. Naver & Daum are listed Search engines list in brave://settings/searchEngines
• Confirmed Google listed as a default SE in brave://settings/searchEngines
• Confirmed Google search in the Search bar for Normal window
• Confirmed Brave search in the Search bar for Private window

Case 2: Upgrade: Modified SE Qwant/Bing - PASSED

1. Continue from Case 1 (Testcase 2 Upgrade)
   • Default SE is Google for Normal window in brave://settings/search
   • Default SE is Brave for Private window in brave://settings/search
2. selected Qwant and Bing as search engines for Normal window and Private window respectively
3. verified Qwant is shown as a default in the Search Engine list in brave://settings/searchEngines
4. renamed the profile Brave-Browser-Beta
5. installed 1.51.84
6. launched Brave
7. opened brave://settings/search
8. opened brave://settings/searchEngines
9. opened a new tab for Normal window
10. opened a new Private window

• Confirmed Qwant and Bing selections are retained upon upgrade in brave://settings/search for Normal window and Private window respectively
• Confirmed updated list Brave, Google. Naver & Daum along with Qwant and Bing are listed Search engines list in brave://settings/searchEngines
• Confirmed Qwant is shown as default in the searchEngine list upon upgrade in brave://settings/searchEngines
• Confirmed Qwant search in the Search bar for Normal window
• Confirmed Bing in the Search bar for Private window

[hffvld]

Verified on Google Pixel 6 and Galaxy Tab S8 using version(s):

Device/OS: 
- Google Pixel 6 [oriole-user 13 TQ2A.230405.003.E1 release-keys]
- SM-X700 Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.51.107 Chromium: 113.0.5672.63 (Official Build) (64-bit)
Revision: 0e1a4471d5ae5bf128b1bd8f4d627c8cbd55f70c-refs/branch-heads/5672@{#912}

---

Clean profile - PASS

• Verified that the search onboarding screen is shown for South Korea
• Verified that only Brave Search, Naver, Daum and Google search providers are available
• Verified that Naver is the default search provider for Normal tab and Private tab
• Verified that Brave search the first one on the list for Normal tab and Private tab
• Verified Naver and Daum thumbnails color in the search bar for Normal tab
• Verified that search results are done by the correct SE for the Normal tab and Private tab

Re: #26318

1	2	3	4
5	6	7	8
Tab 1	Tab 2	Tab 3	Tab 4

Upgraded profile - FAILED

1. Install build 1.50.121 Chromium: 112.0.5615.138

• Verified that the search onboarding screen is shown and Google is the default SE
• Verified that Google is the default search provider for Normal tab and Private tab
• Verified that Brave search the first one on the list for Normal tab and Private tab

2. Change SE to DDG and Bing for Normal tab and Private tab accordingly
3. Upgrade to build 1.51.107 Chromium: 113.0.5672.63

• Observed that DDG and Bing were still selected for Normal tab and Private tab
• Verified that Qwant and Startpage are removed from the list of SE
• Verified that search results are done by search engines that were selected for the Normal tab and Private tab

Phone 1	Phone 2
Tab 1	Tab 2

NOTE: Created follow-up issue #30063