0.00 BAT showing in Rewards panel, even though user is logged in with custodian, and rewards-internals shows Loading...

[Miyayes]

Description

Based on investigation with a user on Uphold, this was due to brave.rewards.external_wallet_type missing from Preferences.

Now received a report of the same on bitFlyer.

cc: @A-t-s-u-s-h-i

[kjozwiak]

The above requires 1.50.121 or higher for 1.50.x verification 👍

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.50.121 Chromium: 112.0.5615.138 (Official Build) (64-bit)
-- | --
Revision | 2258f2fcaeb07bc95c992b7ca47f0b43ead9865c-refs/branch-heads/5615@{#1282}
OS | Windows 10 Version 21H2 (Build 19044.2846)

Per brave/brave-core#18105 (comment), verified the test plan from brave/brave-core#17480 (comment)

Uphold - PASSED

1. Before enabling rewards - PASSED

• Confirmed that there is no Balance info displayed on the brave://rewards-internals page before enabling the rewards

2. After enabling rewards - PASSED

• Confirmed that after enabling the rewards the vBAT balance is shown on the Rewards Internals page
• Confirmed that the Connect account is shown on the brave://rewards settings page, BR panel and rewards NTP widget

Example	Example	Example	Example

3. After connecting a custodial wallet - PASSED

• Confirmed that after connecting custodian wallet, both the vBAT/external wallet balance is displayed on the Rewards Internals page
• Confirmed that after connecting custodian wallet, total balance is displayed on the Rewards page, Rewards panel and Rewards NTP widget

Example	Example	Example	Example

4. Logged out state - PASSED

• Confirmed that in the logged out state, the vBAT balance (zero) is shown only on the Rewards Internals page
• Confirmed that Logged out UI is shown on the brave://rewards, BR panel, Rewards NTP and Tipping banner
• Confirmed that : ( You are currently logged out text message is shown on the tipping banner
  • Note, tipping banner on Nightly 1.52.x will differ from 1.50.x and 1.51.x, this is because new design for tipping banner was merged to Nightly

Example	Example	Example	Example	Example

5. Fail the fetch balance request - PASSED

• Uphold wallet (pre-req: have Charles Proxy set up to return 500 error for the endpoint (https://api-sandbox.uphold.com/v0/me/cards/*))
• Confirmed that spinner animation is shown for both the Rewards BAT (vBAT) and external wallet balance on brave://rewards-internals page

Example	Example	Example	Example

6. Reset rewards - PASSED

• Confirmed that after Reset rewards the wallet balance info is not displayed on the brave://rewards-internals page

Gemini - PASSED

1. Before enabling rewards - PASSED

• Confirmed that there is no Balance info displayed on the brave://rewards-internals page before enabling the rewards

2. After enabling rewards - PASSED

• Confirmed that after enabling the rewards the vBAT balance is shown on the Rewards Internals page
• Confirmed that the Connect account is shown on the brave://rewards settings page, BR panel and rewards NTP widget

Example	Example	Example	Example

3. After connecting a custodial wallet -

• Confirmed that after connecting custodian wallet, both the vBAT/external wallet balance is displayed on the Rewards Internals page
• Confirmed that after connecting custodian wallet, total balance is displayed on the Rewards page, Rewards panel and Rewards NTP widget

Example	Example	Example	Example

4. Logged out state - PASSED

• Confirmed that in the logged out state, the vBAT balance (zero) is shown only on the Rewards Internals page
• Confirmed that Logged out UI is shown on the brave://rewards, BR panel, Rewards NTP and Tipping banner
• Confirmed that : ( You are currently logged out text message is shown on the tipping banner
  • Note, tipping banner on Nightly 1.52.x will differ from 1.50.x and 1.51.x, this is because new design for tipping banner was merged to Nightly

Example	Example	Example	Example	Example

5. Fail the fetch balance request -

• Gemini wallet (pre-req: have Charles Proxy set up to return 500 error for the endpoint (https://api.sandbox.gemini.com/v1/balances))
• Confirmed that spinner animation is shown for both the Rewards BAT (vBAT) and external wallet balance on brave://rewards-internals page

Example	Example	Example	Example

6. Reset rewards - PASSED

• Confirmed that after Reset rewards the wallet balance info is not displayed on the brave://rewards-internals page

bitFlyer - PASSED

1. Before enabling rewards - PASSED

• Confirmed that there is no Balance info displayed on the brave://rewards-internals page before enabling the rewards
  

2. After enabling rewards - PASSED

• Confirmed that after enabling the rewards the vBAT balance is shown on the Rewards Internals page
• Confirmed that the Connect account is shown on the brave://rewards settings page, BR panel and rewards NTP widget

Example	Example	Example	Example

3. After connecting a custodial wallet - PASSED

• Confirmed that after connecting custodian wallet, both the vBAT/external wallet balance is displayed on the Rewards Internals page
• Confirmed that after connecting custodian wallet, total balance is displayed on the Rewards page, Rewards panel and Rewards NTP widget

Example	Example	Example	Example

4. Logged out state - PASSED

• Confirmed that in the logged out state, the vBAT balance (zero) is shown only on the Rewards Internals page
• Confirmed that Logged out UI is shown on the brave://rewards, BR panel, Rewards NTP and Tipping banner
• Confirmed that : ( You are currently logged out text message is shown on the tipping banner
  • Note, tipping banner on Nightly 1.52.x will differ from 1.50.x and 1.51.x, this is because new design for tipping banner was merged to Nightly

Example	Example	Example	Example	Example

5. Fail the fetch balance request - PASSED

• bitflyer wallet (pre-req: have Charles Proxy set up to return "500 Internal Server Error" error for the endpoint (https://demo24kiuw4dcyncsy3qlud8u8.azurewebsites.net/api/link/v1/account/inventory)) - note, this differs from Uphold and Gemini sandbox environments where just returning 500 for the response status is enough
• Confirmed that spinner animation is shown for both the Rewards BAT (vBAT) and external wallet balance on brave://rewards-internals page

Example	Example	Example	Example

6. Reset rewards - PASSED

• Confirmed that after Reset rewards the wallet balance info is not displayed on the brave://rewards-internals page