Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hackerone] Show a prompt for QR-code scanned URLs #29743

Closed
stoletheminerals opened this issue Apr 14, 2023 · 4 comments · Fixed by brave/brave-core#18186
Closed

[hackerone] Show a prompt for QR-code scanned URLs #29743

stoletheminerals opened this issue Apr 14, 2023 · 4 comments · Fixed by brave/brave-core#18186
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include security

Comments

@stoletheminerals
Copy link

stoletheminerals commented Apr 14, 2023

We should show a prompt before navigating to a URL that was scanned with the QR-code scanner.

https://hackerone.com/reports/1946534

Edit: per the latest discussions we decided to go without any prompt but we paste the qr url into address bar but don't submit it, you have press 'return/go' manually

@stoletheminerals stoletheminerals added OS/Android Fixes related to Android browser functionality security labels Apr 14, 2023
@anthonypkeane anthonypkeane added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Apr 15, 2023
@diracdeltas diracdeltas added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 19, 2023
@SergeyZhukovsky SergeyZhukovsky added QA/Yes release-notes/include and removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Apr 19, 2023
@tapanmodh
Copy link

tapanmodh commented Apr 21, 2023

@stoletheminerals If scanned string is not url than we are searching the scanned text to default search engine. should we change that as well?

@stoletheminerals
Copy link
Author

@tapanmodh I don't think it's necessary, thanks for bringing this to my attention though!

@stephendonner
Copy link

Verified PASSED on a Google Pixel XL (arm64) running Android 9:

Brave	1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (32-bit)
Revision	c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS	Android 9; Build/PQ2A.190305.002; 28; REL

Steps:

  1. installed 1.52.102
  2. launched Brave
  3. loaded brave.com on macOS (latest beta)
  4. clicked on its URL bar's Share this page icon
  5. chose Create QR Code
  6. on Android, scanned the above desktop-generated QR code
  7. tapped to load brave.com

Confirmed brave.com URL text was prepopulated in the URL bar, and that I had to tap to load it

example example example example example example
Screenshot 2023-05-18 at 1 38 00 PM Screenshot_20230518-133511 Screenshot_20230518-133520 Screenshot_20230518-133533 Screenshot_20230518-133540 Screenshot_20230518-133601

@hffvld
Copy link
Contributor

hffvld commented May 23, 2023

Verified on Galaxy Tab S8 using version(s):

Device/OS: SM-X700 Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.52.109
Chromium: 114.0.5735.26 (Official Build) beta (64-bit)
Revision: 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}

STEPS:

  1. Install build 1.52.x
  2. Launch Brave
  3. Load brave.com on desktop
  4. Click on its URL bar's Share this page icon
  5. Choose Create QR Code
  6. On Android scan the above desktop-generated QR code
  7. Tap to load brave.com

ACTUAL RESULTS:

  • Verified that the QR code URL was pasted into the address bar automatically, but didn't submit it. User must have to tap 'Enter' manually.
timestamp_13-14-27_13-14-58.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants