Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hackerone] Brave Wallet pop-up hides fullscreen toast #30113

Closed
stoletheminerals opened this issue May 3, 2023 · 2 comments · Fixed by brave/brave-core#19231
Closed

[hackerone] Brave Wallet pop-up hides fullscreen toast #30113

stoletheminerals opened this issue May 3, 2023 · 2 comments · Fixed by brave/brave-core#19231
Assignees
@Pavneet-Sing
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/include security
Milestone
1.58.x - Release

Comments

@stoletheminerals
Copy link

https://hackerone.com/reports/1954620

We should displace Brave Wallet pop-up so it doesn't hide other browser toasts.
@stoletheminerals stoletheminerals added security OS/Android Fixes related to Android browser functionality labels May 3, 2023
@jamesmudgett jamesmudgett added priority/P2 A bad problem. We might uplift this to the next planned release. priority/P3 The next thing for us to work on. It'll ride the trains. priority/P4 Planned work. We expect to get to it "soon". and removed priority/P2 A bad problem. We might uplift this to the next planned release. priority/P3 The next thing for us to work on. It'll ride the trains. labels May 5, 2023
@diracdeltas diracdeltas added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Jun 15, 2023
@diracdeltas
Copy link
Member

@jamesmudgett can we get some design help to come up with a way of showing brave wallet popups that don't interfere with other popups (like the fullscreen toast)?

@Pavneet-Sing Pavneet-Sing mentioned this issue Jul 11, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 12, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.58.117 x64 build. Verification notes can be found here

This was referenced Sep 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/web3/wallet/dapps feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon". QA Pass - Android ARM QA/Yes release-notes/include security
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

fix overlapping toast security issue brave/brave-core
6 participants
@jamesmudgett @diracdeltas @stoletheminerals @Pavneet-Sing @srirambv @brave-builds