Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Custom filter lists via settings #30174

Closed
timchilds opened this issue May 5, 2023 · 5 comments · Fixed by brave/brave-core#19499
Closed

[Android] Custom filter lists via settings #30174

timchilds opened this issue May 5, 2023 · 5 comments · Fixed by brave/brave-core#19499
Assignees
Labels
feature-request OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. privacy/discussed Discussed in privacy confab privacy/feature User-facing privacy- & security-focused feature work. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@timchilds
Copy link

timchilds commented May 5, 2023

Related issue: #26587 (ideally we do both at the same time)

Description

Currently users can add custom filter lists via settings on iOS and Desktop. This ticket is to bring over the same feature to Android.

iOS Filter Lists iOS Add Custom Filter List
image image

Requirements

  • Android users are able to add custom filter lists via settings.
  • The setting should live under Brave Shields & privacy, after the "prevent fingerprinting via language settings" toggle.

Design

If possible copy the iOS layout. If an Android-specific design is required then design is TBD.

cc @deeppandya @anthonypkeane

@timchilds timchilds added OS/Android Fixes related to Android browser functionality privacy/feature User-facing privacy- & security-focused feature work. QA/Yes release-notes/include feature-request privacy/discussed Discussed in privacy confab labels May 5, 2023
@deeppandya deeppandya added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 10, 2023
@deeppandya
Copy link

@tapanmodh
Copy link

thank you @deeppandya

@car12o
Copy link

car12o commented Jul 20, 2023

indeed, this would be super to have on android.
currently, I have to switch browser in order to see some beach cams in my town.

@deeppandya
Copy link

indeed, this would be super to have on android.
currently, I have to switch browser in order to see some beach cams in my town.

@car12o we are currently looking into it and it would be merged into the nightly application soon. So please stay tuned.

@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 11, 2023
@ghost ghost mentioned this issue Sep 14, 2023
Closed
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 21, 2023
@hffvld
Copy link
Contributor

hffvld commented Sep 21, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 UPB5.230623.009 release-keys]
Brave build: 1.59.93
Chromium: 117.0.5938.88 (Official Build) beta (64-bit) 
Revision: 77474ed80832bd2c90be4ebf993b6c2a43f662b0

Filed follow-up issue #33178 and #33180

STEPS:

  1. Follow the steps from [Android] custom filter list settings brave-core#19499 (comment)

ACTUAL RESULTS:

  • Verified that Content Filtering section is added to Brave Shields & privacy
  • Verified that custom filter list can be added to the listes
  • Verified that custom filter list can be disabled
  • Verified that custom filter list can be removed
  • Verified that the same custom filter list can't be added again (duplicates are not allowed)
  • Verified that multiple custom filter lists can be added

1 2 3 4
1 2 3 4
1 2 3 4
1 2 3 4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. privacy/discussed Discussed in privacy confab privacy/feature User-facing privacy- & security-focused feature work. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants