Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News: some images are cropped cutting people's heads off #30271

Closed
petemill opened this issue May 11, 2023 · 4 comments · Fixed by brave/brave-core#18448
Closed

News: some images are cropped cutting people's heads off #30271

petemill opened this issue May 11, 2023 · 4 comments · Fixed by brave/brave-core#18448

Comments

@petemill
Copy link
Member

petemill commented May 11, 2023

Description

On Brave News, images are sources from multiple publishers, each with different aspect ratios. So in order to fill a consistent aspect ratio in Brave News' UI, we inevitably crop many images. We center the image before cropping. Somewhat often this is producing results where subjects' heads are being cut off. We can somewhat aleviate it by changing the alignment to "top".

@stephendonner
Copy link

For posterity, here's the thread: https://bravesoftware.slack.com/archives/CU56GUJ1H/p1683597463587349

And a sample comparison:

Screen Shot 2023-05-23 at 4 41 30 PM

@stephendonner stephendonner added feature/brave-news formerly brave-today bug labels May 26, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.53.67 Chromium: 114.0.5735.53 (Official Build) beta (x86_64)
Revision c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS macOS Version 11.7.7 (Build 20G1345)

Steps:

  1. installed 1.53.67
  2. launched Brave
  3. enabled Brave News
  4. scrolled and noticed GoodHousekeeping articles / photos, in particular
  5. compared to the same in 1.51.114

Confirmed the images appear to be better-scaled, in particular, not cropped at the top/head

1.53.67 1.51.114
Screen Shot 2023-05-26 at 5 52 47 PM Screen Shot 2023-05-26 at 5 52 40 PM

@kjozwiak
Copy link
Member

kjozwiak commented Jul 5, 2023

The above requires 1.52.130 or higher for 1.52.x verification 👍 Removing the QA Pass label as the above will need to be rechecked with 1.52.x.

@LaurenWags
Copy link
Member

LaurenWags commented Jul 6, 2023

Verified with

Brave | 1.52.130 Chromium: 114.0.5735.198 (Official Build) (x86_64)
-- | --
Revision | c3029382d11c5f499e4fc317353a43d411a5ce1c-refs/branch-heads/5735@{#1394}
OS | macOS Version 13.4.1 (Build 22F82)

Steps:

  1. installed 1.52.129
  2. launched Brave
  3. enabled Brave News
  4. found an example with the head cut off
  5. compared to the same in 1.52.130

Confirmed the images appear to be better-scaled, in particular, not cropped at the top/head

1.52.129 1.52.130
129 130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants